New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856662 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 854561



Sign in to add a comment

Icon size in user menu is incorrect

Project Member Reported by maxwalker@chromium.org, Jun 26 2018

Issue description

Chrome Version: 69.0.3473.0
OS: Windows, macOS, Linux

Icons are 20x20dp, but should be 16x16dp according to the specs: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr62j8zhBiGlBGhLW3sTdTBWc.
 
Specs.png
139 KB View Download

Comment 1 by ew...@chromium.org, Jun 26 2018

Cc: markchang@chromium.org
I don't think anyone on the sign in team is going to have time to pick this up in the near term. Someone from either desktop or autofill teams should feel free to pick this up if they have time.
Owner: bettes@chromium.org
alan, wdyt? I think this is skippable for m69.
I'd vote for fixing in 69. Today's sizing makes go/autofill-home feel quite clunky :/ 

For my eyes, it's because the gray icons feel bloated next to their profile-icon peers:
https://screenshot.googleplex.com/yjkVEafZE6q.png
Labels: Hotlist-Polish Proj-MdRefresh
Owner: ----
Status: Available (was: Untriaged)
The icons, row heights, and highlight color of the user menu are inconsistent with the page info bubble. That is true. 

The right labels are applied so we won't lose track of it. 
We have 20 P1s still to tackle before branch so it's unlikely we'll get to it by 69. 

Here's 2 bug lists of the people that would pick up that work. Let us know if there's something we shouldn't be prioritizing here. 

https://bugs.chromium.org/p/chromium/issues/list?can=2&q=Proj%3DMdRefresh+owner%3Absep%40chromium.org+&sort=pri+-opened&colspec=Type+ID+Pri+Opened+Cr+Owner+Summary+EstimatedDays+BlockedOn&x=m&y=releaseblock&cells=ids

https://bugs.chromium.org/p/chromium/issues/list?can=2&q=Proj%3DMdRefresh+owner%3Apbos%40chromium.org+&sort=pri+-opened&colspec=Type+ID+Pri+Opened+Cr+Owner+Summary+EstimatedDays+BlockedOn&x=m&y=releaseblock&cells=ids


Master bug list: go/gm2-triage



Mis-spoke on the highlight color but row heights filed at Issue 859961
Owner: vasi...@chromium.org
Status: Assigned (was: Available)
I think Vasilii might be able to cover this. What is the desired spec, Alan/Max?
Specs are linked in first comment.

Adding 16dp icons for passwords, payment methods and addresses.
ic_location_on_black_16dp.svg
998 bytes Download
ic_payment_black_16dp.svg
923 bytes Download
ic_vpn_key_black_16dp.svg
1.3 KB Download
Labels: Group-Toolbar
Labels: -Group-Toolbar Group-Avatar_Button
Triage: How's this looking for M69?
The fix will happen after the branch point. Then, let's try to merge.
Labels: M-69 Target-69
How's this going? We would like to get this in soon for M69.
Joel, could you add the 16x16dp icons from your GM2 specs (https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdCCzipS_DuF/files/MCHbtQVoQ2HCZSx9ovjMmSIw):

- Guest
- Manage (settings)
- Exit/close

Thanks!
Those two are missing:
- settings (settings.icon)
- close all (close_all.icon)

The guest is fine.

Screenshot from 2018-07-27 17-02-53.png
22.1 KB View Download
The CL is https://chromium-review.googlesource.com/c/chromium/src/+/1152983

If you post the two missing icons, then I can add them.
Cc: -sabineb@chromium.org
Owner: bklmn@chromium.org
Assigning to Joel to make sure he sees this.
Blocking: 854561
Labels: -Pri-2 Pri-1
This seems to be blocking the Autofill Home launch. Would be good to get the assets asap. Thanks Joel!
Owner: vasi...@chromium.org
Adding missing icons.
ic_close_all_black_16dp.svg
1.8 KB Download
ic_settings_black_16dp.svg
2.2 KB Download
Screenshot from 2018-07-31 13-15-07.png
22.9 KB View Download
Looks beautiful to me. Wdyt, Max?
LGTM, thanks!
Labels: Merge-Request-69
I want to merge r579387 back. It's a very desired UI fix.
Project Member

Comment 25 by sheriffbot@chromium.org, Aug 2

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 2

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34066dc30ed40bf5145a1f4835821df33acb7d97

commit 34066dc30ed40bf5145a1f4835821df33acb7d97
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Aug 02 11:21:56 2018

Change the icon size to 16dp in the profile chooser.

The CL also updates the actual Autofill Home icons with the required size.

TBR=vasilii@chromium.org

(cherry picked from commit ed60367fd5aee162692049220741b6506cb75027)

Bug:  856662 
Change-Id: I3b8df3dec255cb703bd856183de30490640638a1
Reviewed-on: https://chromium-review.googlesource.com/1152983
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579387}
Reviewed-on: https://chromium-review.googlesource.com/1160311
Cr-Commit-Position: refs/branch-heads/3497@{#333}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/chrome/app/vector_icons/close_all.icon
[modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/chrome/app/vector_icons/credit_card.icon
[modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/chrome/app/vector_icons/key.icon
[modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/chrome/app/vector_icons/settings.icon
[modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/components/vector_icons/location_on.icon

Status: Fixed (was: Assigned)
Labels: TE-Verified-69.0.3497.32 TE-Verified-M69
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #69.0.3473.0

Verified the fix on Mac 10.12.5 and Ubuntu 17.10 using Chrome version #69.0.3497.32 as per the comment #0.
Attaching screen shot for reference.
Observed that icons in user menu are 16x16dp.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
856662.png
528 KB View Download
Cc: abdulsyed@chromium.org
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh .

Sign in to add a comment