Icon size in user menu is incorrect |
||||||||||||||||
Issue descriptionChrome Version: 69.0.3473.0 OS: Windows, macOS, Linux Icons are 20x20dp, but should be 16x16dp according to the specs: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr62j8zhBiGlBGhLW3sTdTBWc.
,
Jun 27 2018
alan, wdyt? I think this is skippable for m69.
,
Jun 27 2018
I'd vote for fixing in 69. Today's sizing makes go/autofill-home feel quite clunky :/ For my eyes, it's because the gray icons feel bloated next to their profile-icon peers: https://screenshot.googleplex.com/yjkVEafZE6q.png
,
Jun 30 2018
,
Jul 3
The icons, row heights, and highlight color of the user menu are inconsistent with the page info bubble. That is true. The right labels are applied so we won't lose track of it. We have 20 P1s still to tackle before branch so it's unlikely we'll get to it by 69. Here's 2 bug lists of the people that would pick up that work. Let us know if there's something we shouldn't be prioritizing here. https://bugs.chromium.org/p/chromium/issues/list?can=2&q=Proj%3DMdRefresh+owner%3Absep%40chromium.org+&sort=pri+-opened&colspec=Type+ID+Pri+Opened+Cr+Owner+Summary+EstimatedDays+BlockedOn&x=m&y=releaseblock&cells=ids https://bugs.chromium.org/p/chromium/issues/list?can=2&q=Proj%3DMdRefresh+owner%3Apbos%40chromium.org+&sort=pri+-opened&colspec=Type+ID+Pri+Opened+Cr+Owner+Summary+EstimatedDays+BlockedOn&x=m&y=releaseblock&cells=ids Master bug list: go/gm2-triage
,
Jul 3
Mis-spoke on the highlight color but row heights filed at Issue 859961
,
Jul 4
I think Vasilii might be able to cover this. What is the desired spec, Alan/Max?
,
Jul 4
Specs are linked in first comment. Adding 16dp icons for passwords, payment methods and addresses.
,
Jul 12
,
Jul 19
Triage: How's this looking for M69?
,
Jul 19
The fix will happen after the branch point. Then, let's try to merge.
,
Jul 26
,
Jul 26
How's this going? We would like to get this in soon for M69.
,
Jul 27
Joel, could you add the 16x16dp icons from your GM2 specs (https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdCCzipS_DuF/files/MCHbtQVoQ2HCZSx9ovjMmSIw): - Guest - Manage (settings) - Exit/close Thanks!
,
Jul 27
Those two are missing: - settings (settings.icon) - close all (close_all.icon) The guest is fine.
,
Jul 30
The CL is https://chromium-review.googlesource.com/c/chromium/src/+/1152983 If you post the two missing icons, then I can add them.
,
Jul 30
Assigning to Joel to make sure he sees this.
,
Jul 30
This seems to be blocking the Autofill Home launch. Would be good to get the assets asap. Thanks Joel!
,
Jul 30
Adding missing icons.
,
Jul 31
,
Jul 31
Looks beautiful to me. Wdyt, Max?
,
Jul 31
LGTM, thanks!
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed60367fd5aee162692049220741b6506cb75027 commit ed60367fd5aee162692049220741b6506cb75027 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Tue Jul 31 13:27:39 2018 Change the icon size to 16dp in the profile chooser. The CL also updates the actual Autofill Home icons with the required size. Bug: 856662 Change-Id: I3b8df3dec255cb703bd856183de30490640638a1 Reviewed-on: https://chromium-review.googlesource.com/1152983 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579387} [modify] https://crrev.com/ed60367fd5aee162692049220741b6506cb75027/chrome/app/vector_icons/close_all.icon [modify] https://crrev.com/ed60367fd5aee162692049220741b6506cb75027/chrome/app/vector_icons/credit_card.icon [modify] https://crrev.com/ed60367fd5aee162692049220741b6506cb75027/chrome/app/vector_icons/key.icon [modify] https://crrev.com/ed60367fd5aee162692049220741b6506cb75027/chrome/app/vector_icons/settings.icon [modify] https://crrev.com/ed60367fd5aee162692049220741b6506cb75027/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/ed60367fd5aee162692049220741b6506cb75027/components/vector_icons/location_on.icon
,
Aug 1
,
Aug 2
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34066dc30ed40bf5145a1f4835821df33acb7d97 commit 34066dc30ed40bf5145a1f4835821df33acb7d97 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Aug 02 11:21:56 2018 Change the icon size to 16dp in the profile chooser. The CL also updates the actual Autofill Home icons with the required size. TBR=vasilii@chromium.org (cherry picked from commit ed60367fd5aee162692049220741b6506cb75027) Bug: 856662 Change-Id: I3b8df3dec255cb703bd856183de30490640638a1 Reviewed-on: https://chromium-review.googlesource.com/1152983 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579387} Reviewed-on: https://chromium-review.googlesource.com/1160311 Cr-Commit-Position: refs/branch-heads/3497@{#333} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/chrome/app/vector_icons/close_all.icon [modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/chrome/app/vector_icons/credit_card.icon [modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/chrome/app/vector_icons/key.icon [modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/chrome/app/vector_icons/settings.icon [modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/34066dc30ed40bf5145a1f4835821df33acb7d97/components/vector_icons/location_on.icon
,
Aug 2
,
Aug 9
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #69.0.3473.0 Verified the fix on Mac 10.12.5 and Ubuntu 17.10 using Chrome version #69.0.3497.32 as per the comment #0. Attaching screen shot for reference. Observed that icons in user menu are 16x16dp. Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Aug 14
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh . |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by ew...@chromium.org
, Jun 26 2018