New issue
Advanced search Search tips

Issue 856646 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

No longer autofilling with --enable-features=new-password-form-parsing

Project Member Reported by vabr@chromium.org, Jun 26 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(0) Run Chrome with --enable-features=new-password-form-parsing
(1) Go to https://booking.flyfrontier.com/Flight/Select.
(2) Save some credentials on the sign-in form.
(3) Reload the sign-in form.

What is the expected result?
Credentials get autofilled.

What happens instead?
The can only be filled on demand, not automatically.

Notes: with --disable-features=new-password-form-parsing it autofills.
 

Comment 1 by dvadym@chromium.org, Jun 29 2018

There are 2 password forms:
1.On the main page https://booking.flyfrontier.com/ It's filled both with new and old parsing.
2.When to click sing-in on https://booking.flyfrontier.com/Flight/Select . It's not filled nor with new nor with old parsing. The problem is that there is not <form> flag and so it's considered as big synthetic which actually contains sign-up + sign-in form. It's hard to parse it right:

Fields:
email: 420638584, type=text, autocomplete=off
email: 420638584, type=text
confirm_email: 2380180936, type=text
password: 2051817934, type=password, autocomplete=off
confirm_password: 822190368, type=password
first_name: 1938669551, type=text
middle_name: 2842732069, type=text
last_name: 3389759488, type=text
: 4203909268, type=select-one
gender: 357851563, type=select-one
birth_date: 2138399214, type=text
phone: 1794903826, type=tel
address1: 2267517795, type=text
address2: 1236818338, type=text
city: 2098554694, type=text
state: 1878375253, type=select-one
zip_code: 2512693257, type=text
email: 420638584, type=text, autocomplete=off
password: 2051817934, type=password, autocomplete=off

New parsing says 
Username element : email 
 and 
New password element : password that's correct :).

Comment 2 by dvadym@chromium.org, Jun 29 2018

Labels: -Pri-2 Pri-3
So it's not regression in new parsing, that's good. In future we can think how to parse such complex forms.

Sign in to add a comment