New issue
Advanced search Search tips

Issue 856633 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Cells should have an animate out animation when swiping to delete

Project Member Reported by pschaffner@chromium.org, Jun 26 2018

Issue description

If there is something we can get for free, use it, if not, assign to Martijn or myself to spec.
 

Comment 1 by sczs@chromium.org, Jun 26 2018

Cc: -sczs@chromium.org thegreenfrog@chromium.org
Labels: -Pri-1 Pri-2
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Pri-2 M-70 Pri-1
Labels: -Q2
Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)
Sadly this is not going to be a straightforward change, and I think we should tackle this after the legacy code has been deleted.

Currently the Bookmarks Service is handling the model, that means that whenever we delete something from the TableView, we asks the service first, and then once the service has deleted the item, it tells the TableView to update itself. 

The updates are pretty generic and don't give the TableView much information, so the TableView pretty much reloads itself completely. This is why we don't have animations, a full reload doesn't produce any.

We need to know which rows/items were deleted so we can delete their rows directly, instead of asking the TableView to recalculate everything which will end up "deleting" those rows since they don't exist in the model anymore. 

In order to achieve this we need to change the way we handle these updates, similar changes were done for the new TabGrid, so I might base myself on that.
Labels: -M-70 M-71

Sign in to add a comment