Incorrect label layout for some bookmarks |
||||
Issue descriptionSeems to be bookmarks that don't have true URLs, and those have a wonky layout. For those scenarios, we should just show the title label and center it vertically.
,
Jun 27 2018
Can I get a screenshot? I can't seem to reproduce what you are describing.
,
Jun 28 2018
I attached a screenshot, but one way to repo on your end is to create a bookmark with any non-url string for the URL field (one example of this in practice would be a javascript bookmarklet).
,
Aug 7
Let's try to get collections polish in M70.
,
Aug 8
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89ba39268d752cf1c4410e24ea073da13267bd71 commit 89ba39268d752cf1c4410e24ea073da13267bd71 Author: Chris Lu <thegreenfrog@chromium.org> Date: Tue Aug 14 16:25:54 2018 [ios] Center Title Label if no url in TableViewUrlCell If no metadata label is set, alignment property of horizontal stack view should be fill so that the vertical stackview can fill entire vertical space. If URLlabel has no text, then it should be hidden so that the title label can be centered within the vertical stackview. Screenshots: https://drive.google.com/file/d/1rOS-DUahkcpX-Lk-iGB6IsYO8DZdKwiF/view?usp=sharing https://drive.google.com/file/d/12Sl-CL00bCdi2atkM4HKl7XFWSAxNBNP/view?usp=sharing Bug: 856620 Change-Id: I84b932600487fa17cc3aa2b55accbfc5d71d8eca Reviewed-on: https://chromium-review.googlesource.com/1167745 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582932} [modify] https://crrev.com/89ba39268d752cf1c4410e24ea073da13267bd71/ios/chrome/browser/ui/bookmarks/cells/bookmark_home_node_item.mm [modify] https://crrev.com/89ba39268d752cf1c4410e24ea073da13267bd71/ios/chrome/browser/ui/history/history_entry_item.mm [modify] https://crrev.com/89ba39268d752cf1c4410e24ea073da13267bd71/ios/chrome/browser/ui/reading_list/reading_list_table_view_item.mm [modify] https://crrev.com/89ba39268d752cf1c4410e24ea073da13267bd71/ios/chrome/browser/ui/table_view/cells/table_view_url_item.h [modify] https://crrev.com/89ba39268d752cf1c4410e24ea073da13267bd71/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
,
Aug 14
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sczs@chromium.org
, Jun 26 2018Owner: thegreenfrog@chromium.org
Status: Assigned (was: Untriaged)