MacViews: Tabs opened in background are not rendering, need reload |
||||||||||
Issue descriptionChrome Version: 69.0.3473.0 OS: 10.13.4 What steps will reproduce the problem? (1) Enable #upcoming-ui-features (2) Command-click a link or otherwise open a tab in the background (3) Switch to the newly opened tab What is the expected result? Page is rendered What happens instead? Blank white space. Reload is required to get the page to load.
,
Jun 26 2018
Could you bisect this?
,
Jun 26 2018
It was fine yesterday, so it's basically prebisected :) https://chromium.googlesource.com/chromium/src/+log/69.0.3472.0..69.0.3473.0?pretty=fuller&n=10000 Maybe https://chromium.googlesource.com/chromium/src/+/2673cbdbabf67ea74d3f5267e1745224e79ad2d3 ?
,
Jun 26 2018
,
Jun 26 2018
Sorry, missed lgrey@'s comment.
,
Jun 26 2018
Manual revert of https://chromium.googlesource.com/chromium/src/+/2673cbdbabf67ea74d3f5267e1745224e79ad2d3 seems to do the trick, so I think that's it
,
Jun 27 2018
I just had this open a YouTube video, and when I switched to the tab, the audio DID start autoplaying, so the renderer is definitively active, just missing the paint.
,
Jun 27 2018
Have we reverted that patch yet?
,
Jun 27 2018
No. I didn't want to do it myself since I was thinking someone more familiar with paint would have a better fix forward than RequestRepaintForTesting
,
Jun 27 2018
I think we basically want to do what Aura does: https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_aura.cc?sq=package:chromium&targetos=chromium-android&q=RenderWidgetHostViewAura::Show&g=0&l=660 Does that fix it? I don't have a ready Mac build at the moment.
,
Jun 27 2018
I'll take a look here.
,
Jun 27 2018
I've reverted the offending CL.
,
Jun 27 2018
Okay thanks. I'm writing a CL to apply the recommendations of fsamuel in c#10. It's mostly a reorganization of code rather than a revolution.
,
Jul 12
,
Jul 12
Triage: Any further work to be done here?
,
Jul 12
Issue 856579 has been merged into this issue.
,
Jul 12
The CL that caused this was rolled back. There's a better fix out for review at https://chromium-review.googlesource.com/c/chromium/src/+/1117762 but the overall issue is fixed, so I'm going to close for triage purposes.
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7ed5d5cb7442e7fa82a1ddc8e53edf3a1263ab4 commit b7ed5d5cb7442e7fa82a1ddc8e53edf3a1263ab4 Author: Tommy C. Li <tommycli@chromium.org> Date: Thu Jul 19 00:58:39 2018 MacViews: Fix rendering of tabs opened in the background (middle-click) Currently we rely on test-only code to render tabs opened in the background. This CL updates RenderWidgetHostViewMac to not rely on test-only code and does an Aura-analogous operation to render background tabs. It also makes the Mac version of WasUnOccluded contain all the meat of the Aura version. Bug: 856617 Change-Id: Id9f05f627cbadb542772a200f2608787f05a63b7 Reviewed-on: https://chromium-review.googlesource.com/1117762 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576290} [modify] https://crrev.com/b7ed5d5cb7442e7fa82a1ddc8e53edf3a1263ab4/content/browser/renderer_host/browser_compositor_view_mac.h [modify] https://crrev.com/b7ed5d5cb7442e7fa82a1ddc8e53edf3a1263ab4/content/browser/renderer_host/browser_compositor_view_mac.mm [modify] https://crrev.com/b7ed5d5cb7442e7fa82a1ddc8e53edf3a1263ab4/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/b7ed5d5cb7442e7fa82a1ddc8e53edf3a1263ab4/content/browser/renderer_host/render_widget_host_view_mac.mm
,
Jul 20
Verified the fix on Mac 10.13.1 using Chrome version #69.0.3497.0 as per the comment #0. Attaching screen cast for reference. Observed that pages rendered without having to refresh it after relaunch. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version 69.0.3473.0 Thanks...!! |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ccameron@chromium.org
, Jun 26 2018