New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 856613 link

Starred by 1 user
Status: Fixed
Owner:
shend@chromium.org
Closed: Jul 3
Cc:
█ blakeo@chromium.org
omrilio@chromium.org
yhanada@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

#enable-emoji-context-menu keyboard appears only on primary monitor

Reported by tri...@gmail.com, Jun 26 2018 
Chrome Version: 69.0.3464.0
OS Version: 10798.0.0

What steps will reproduce the problem?
1. enable #enable-emoji-context-menu
2. attempt to use the emoji context menu on a second display (multi-monitor setup)
3. the on screen keyboard appears on the primary display

What is the expected result?
- the onscreen keyboard should appear on the secondary display

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 10798.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3464.0 Safari/537.36

Comment 1 by dtapu...@chromium.org, Jun 26 2018

Components: UI>Input>VirtualKeyboard

Comment 2 by shend@chromium.org, Jun 27 2018

Owner: shend@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 3 by shend@chromium.org, Jun 27 2018

Cc: blakeo@chromium.org
Thanks for reporting the bug. Does your secondary monitor have touch support?

+blakeo who has worked with multiple monitors. AFAIK the VK only appears in the focused text field if it has touch support right? Can I call |ShowKeyboardInDisplay| to force it to show in a particular monitor?

Comment 4 by tri...@gmail.com, Jun 27 2018 

My displays are non-touch (1920x1200 hdmi).

Here's a screenshot. As you can see, right-click and choosing emoji on the right (secondary) display shows the vkb on the left (primary) display.
dual.png
538 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/019eb9605d08b14a5a796c8e8071fd96775b3a02

commit 019eb9605d08b14a5a796c8e8071fd96775b3a02
Author: Darren Shen <shend@chromium.org>
Date: Mon Jul 02 05:15:00 2018

[VK] Move keyboard to focused display if no display is touchable.

Currently when no display is touchable, we show the virtual keyboard
on the primary display. According to  https://crbug.com/297858 , this
was just a basic heuristic to get it working. As mentioned in
 https://crbug.com/303429#c5 , forcing the user to change their primary
display all the time is not very user friendly.

We change this so that when no display is touchable, we show the
keyboard on the focused window (if any).

Bug:  856613 
Change-Id: I4e0524747c54e471607b2b546a3ef663ad215b55
Reviewed-on: https://chromium-review.googlesource.com/1118060
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571822}
[modify] https://crrev.com/019eb9605d08b14a5a796c8e8071fd96775b3a02/ash/keyboard/virtual_keyboard_controller.cc
[modify] https://crrev.com/019eb9605d08b14a5a796c8e8071fd96775b3a02/ash/keyboard/virtual_keyboard_controller_unittest.cc
[modify] https://crrev.com/019eb9605d08b14a5a796c8e8071fd96775b3a02/testing/buildbot/filters/mash.ash_unittests.filter

Comment 6 by shend@chromium.org, Jul 3

Status: Fixed (was: Assigned)
Should be fixed now for M69.

Comment 7 by tri...@gmail.com, Jul 23 

Confirmed that the OSK now shows on the correct monitor in Version 69.0.3494.0
►

Sign in to add a comment