Picture-in-Picture window is not always on top after entering the second time |
|||||||||||
Issue descriptionChromium Version : 69.0.3474.0 What steps will reproduce the problem? 1. The chrome://flags/#enable-surfaces-for-videos flag must be enabled. 2. Go to https://googlechrome.github.io/samples/picture-in-picture/ 3. Play video, enter Picture-in-Picture, and exit Picture-in-Picture 4. Enter Picture-in-Picture for the second time 5. Click browser window (not Picture-in-Picture window) What is the expected result? The Picture-in-Picture window should stay on top. What happens instead of that? The Picture-in-Picture window is hidden by browser window.
,
Jun 26 2018
Hello Tom, is this something you're aware of?
Calling code below doesn't seem to make window always on top afterwards. Is that a known issue?
ui::SetWMSpecState(xwindow_, true, gfx::GetAtom("_NET_WM_STATE_ABOVE"), x11::None);
Note that I use Fluxbox.
,
Jun 27 2018
I was also able to reproduce on XFCE using xfwm4 window manager.
,
Jun 27 2018
To be clear, this is not specific to Picture-in-Picture window. I can also reproduce with a Chrome App. 1. Install https://chrome.google.com/webstore/detail/window-options-sample/cfcgoifcnpnadlhhoolkemkjkhoajfmk 2. Launch app window 3. Mark it "Always on top" by checking the appropriate checkbox in "Edit current window" tab 4. Verify successfully that it is always on top. 5. Click "Hide, then Show" button 6. window is not Always on top anymore ;( This is Linux only, I can't reproduce with Chrome OS.
,
Jun 27 2018
,
Jun 27 2018
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/270b2bfa01f4eadfe6f25673767a3357158e0ef9 commit 270b2bfa01f4eadfe6f25673767a3357158e0ef9 Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Jun 29 18:29:45 2018 X11: Restore window state when re-Show()ing a hidden window Most window managers clear the _NET_WM_STATE property when a window is unmapped, as specified by the EWMH spec [1]. This means if apps set always-on-top for a window which is hidden and then shown, the window will no longer be always-on-top. This CL restores the state set by Chrome when a window is re-mapped. [1] https://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317598336 BUG= 856607 Change-Id: I1c72d9b20c0b68198c7f3d0f31ea28ce5e6f2da3 Reviewed-on: https://chromium-review.googlesource.com/1117439 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#571555} [modify] https://crrev.com/270b2bfa01f4eadfe6f25673767a3357158e0ef9/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc [modify] https://crrev.com/270b2bfa01f4eadfe6f25673767a3357158e0ef9/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
,
Jun 29 2018
,
Jul 2
I'm using Chromium 69.0.3480.0 on Linux and window is still not "Always on top" sadly. I can reproduce for Picture-in-Picture window and Chrome Apps windows.
,
Jul 2
Able to reproduce this issue on Ubuntu 17.10 on the reported version 69.0.3474.0 and the issue seems to be fixed on the latest Canary 69.0.3479.0 by following the steps given in the original comment. Can observe the Picture-in-Picture window on the top after clicking on the Toggle Picture-In button the second time. Attached is the screen cast for reference. @thomasanderson : Request you to please check and confirm if the issue is fixed on the latest M-69 build. Thanks..
,
Jul 2
Not fixed yet
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f400ee616ac4b8b5cb8782b424dbb156d6aaab44 commit f400ee616ac4b8b5cb8782b424dbb156d6aaab44 Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Jul 03 18:59:17 2018 X11: Add missing initialization for window state list This is a followup to: https://chromium.googlesource.com/chromium/src.git/+/270b2bfa01f4eadfe6f25673767a3357158e0ef9 BUG= 856607 R=sadrul CC=fbeaufort Change-Id: If06c971a309b4630e44184f7a08bb156b620c7ec Reviewed-on: https://chromium-review.googlesource.com/1123367 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#572311} [modify] https://crrev.com/f400ee616ac4b8b5cb8782b424dbb156d6aaab44/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
,
Jul 3
,
Jul 4
Verified in Chromium 69.0.3482.0 (Developer Build) (64-bit)
,
Jul 4
Able to reproduce the issue on chrome version 69.0.3474.0(build without fix) Verified the fix on Ubuntu 14.04 and 17.10 using Chrome version #69.0.3481.0 as per the comment #0. Attaching screen-cast for reference. Observed that "The Picture-in-Picture window stayed on top." Adding verified labels as fix is working as expected. Thanks...!! |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by fbeaufort@chromium.org
, Jun 26 2018Status: Assigned (was: Unconfirmed)