Issue metadata
Sign in to add a comment
|
Cutting url from address bar does not encoded reserved characters
Reported by
william.groenendijk@gmail.com,
Jun 26 2018
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Steps to reproduce the problem: 1. Go to http://www.justarrangingbits.org/firefox-magic-decoding-address-bar/index.html?test=%5E%7B%7D%5B%5D%22%5C%3C%3E%60%7C 2. Notice how %22, %3C and %3E get decoded to ", < and > in the address bar (the URL you see in the address bar is http://www.justarrangingbits.org/firefox-magic-decoding-address-bar/index.html?test=%5E%7B%7D%5B%5D"%5C<>%60%7C) 3. Cut (CTRL+X, context menu) the URL from the address bar, and paste it somewhere that's not the address bar. What is the expected behavior? The pasted URL should be the same as when you copy (CTRL+C, context menu), with all reserved characters encoded: http://www.justarrangingbits.org/firefox-magic-decoding-address-bar/index.html?test=%5E%7B%7D%5B%5D%22%5C%3C%3E%60%7C What went wrong? Not all reserved characters in the URL were properly encoded in the pasted output: http://www.justarrangingbits.org/firefox-magic-decoding-address-bar/index.html?test=%5E%7B%7D%5B%5D"%5C<>%60%7C Did this work before? N/A Chrome version: <Copy from: 'about:version'> Channel: stable OS Version: 10.0 Flash Version: Firefox also shows decoded reserved characters in the address bar, but encodes it as expected for both cut and copy.
,
Jun 26 2018
,
Jun 27 2018
Able to reproduce the issue on Win-10 and Ubuntu 17.10 using chrome reported version #67.0.3396.99 but the same is not reproducible in the latest canary #69.0.3473.0. Issue is not seen in OS-mac. Reverse Bisect Information: ===================== Good build: 68.0.3421.0 Bad Build : 68.0.3420.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/56a1674641d7434b8ced8020b6790b441ae89633..ad2bd3c676dc9f2678293901c4c077e800ff33b9 From the above change log suspecting below change Change-Id: Iae3ee431051e2f7bbbf63a0b87e82b7f363213aa Reviewed-on: https://chromium-review.googlesource.com/1040912 tommycli@ - Could you please check and merge the fix to M-67 if it is a valid candidate. Note: Adding stable blocker for M-67 as it seems to be a recent regression. Please feel free to remove the same if not appropriate. Thanks...!!
,
Jun 27 2018
I was able to talk to pbommana about this issue. He has confirmed that it's working properly in 68 Beta channel and later. Therefore users will receive the fix automatically once 68 is released and we do not require a merge.
,
Jun 27 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.
,
Jun 27 2018
Removing "Merge-TBD" label per comment #4. Thank you.
,
Jul 3
Able to reproduce the issue on Win-10 using chrome build without fix. Verified the fix on Win-10 and Ubuntu 17.10 using latest chrome beta version #68.0.3440.42 as per the comment #0. Attaching screen cast for reference. Observed that pasted URL is the same as when we copy (CTRL+C, context menu), with all reserved characters encoded: http://www.justarrangingbits.org/firefox-magic-decoding-address-bar/index.html?test=%5E%7B%7D%5B%5D%22%5C%3C%3E%60%7C Hence, the fix is working as expected. Adding the verified labels. Thanks...!! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by william.groenendijk@gmail.com
, Jun 26 2018