New issue
Advanced search Search tips

Issue 856568 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Use appropriate task runners for queued events

Project Member Reported by hajimehoshi@chromium.org, Jun 26 2018

Issue description

If you find an event queued to an inappropriate task runner, let's fix this to an appropriate task runner.

Note that some events doesn't require appropriate task runners.

Our long-term goal is to improve UX by making the scheduler cleverer. 
 
Labels: -Pri-3 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dc37fb179cf720b66d80c69fa41543ed3c95273

commit 8dc37fb179cf720b66d80c69fa41543ed3c95273
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Jun 27 06:07:04 2018

Add TaskType to LocalDOMWindow::EnqueueWindowEvent

This CL adds an argument TaskType to LocalDOMWindow::EnqueueWindowEvent
so that callers can specify a task source.

Bug: 856568
Change-Id: Ied2da83d39b3be92ccd9baebbf61f3f80b35f43b
Reviewed-on: https://chromium-review.googlesource.com/1114672
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570674}
[modify] https://crrev.com/8dc37fb179cf720b66d80c69fa41543ed3c95273/third_party/blink/renderer/core/editing/frame_selection.cc
[modify] https://crrev.com/8dc37fb179cf720b66d80c69fa41543ed3c95273/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/8dc37fb179cf720b66d80c69fa41543ed3c95273/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/8dc37fb179cf720b66d80c69fa41543ed3c95273/third_party/blink/renderer/core/page/pointer_lock_controller.cc
[modify] https://crrev.com/8dc37fb179cf720b66d80c69fa41543ed3c95273/third_party/blink/renderer/modules/storage/storage_area.cc
[modify] https://crrev.com/8dc37fb179cf720b66d80c69fa41543ed3c95273/third_party/blink/renderer/modules/vr/navigator_vr.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93308699ec544ab1123a6e055a8d8802a95f5d9b

commit 93308699ec544ab1123a6e055a8d8802a95f5d9b
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Aug 27 11:02:47 2018

Use a per-frame task runner at RenderFrameImpl::OnPostMessageEvent

This is part of efforts to replace per-thread task runner usages with
per-frame task runners.

We tried to replace legacy IPC with Mojo first, but failed due to a
message order issue (see https://chromium-review.googlesource.com/c/chromium/src/+/1174341/2/content/common/frame.mojom#65).
Until this problem is solved, just replacing the task runner at the
accepting side would work.

Bug: 856568
Change-Id: I57f067cd34638eba6fd8bcce29e23e79c6ee7490
Reviewed-on: https://chromium-review.googlesource.com/1184739
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586230}
[modify] https://crrev.com/93308699ec544ab1123a6e055a8d8802a95f5d9b/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/93308699ec544ab1123a6e055a8d8802a95f5d9b/content/renderer/render_frame_impl.h

Sign in to add a comment