New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856567 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Files app: Android app cannot open files in media view.

Project Member Reported by fukino@chromium.org, Jun 26 2018

Issue description

Chrome Version: 68.0.3440.34
OS: Chrome

What steps will reproduce the problem?
(1) Enable Play Store and install an Android app which can open image files. (e.g. Google Photos)
(2) Open Files app.
(3) Copy an image file to Downloads. The image should be shown in Images/Downloads/ 
(4) Select the image in Images/Downloads/, and select "Upload to Photos" from the share option menu on the toolbar.

What is the expected result?
The image is sent to Google Photos app

What happens instead?
Nothing happens.


I confirmed this issue on Eve M68 beta.
I'll check the stable channel.
 

Comment 1 by fukino@chromium.org, Jun 26 2018

Labels: M-67
Unfortunately, it reproduced on M67 stable too...

Comment 2 by fukino@chromium.org, Jun 26 2018

To pass CTS, ArcFileSystemService and ArcIntentHelper are running in different UID now.
Due to this change, ArcIntentHelper lost a permission to access media files in MediaDocumentsProvider, since only one UI can have the permission and ArcFileSystemService has it.

This explain the current symptom, and a possible workaround is that modifying ArcIntentHelper to directly access MediaProvider instead of MediaDocumentsProvider by generating media URLs.
I'll try this workaround.

Comment 3 by fukino@chromium.org, Jun 26 2018

Cc: weifangsun@chromium.org
According to nya@, reverting the change will be dangerous.
I'm going to make a fix and merge it to M68, since M67 is already stable for a while.
+weifangsun@ for double check about schedule for the fix.

Comment 4 by nya@chromium.org, Jun 26 2018

Thanks Fukino-san for catching this issue. It's bad I did not notice this earlier...

After offline discussion, I got an idea of another approach. The problem here is not specific to MediaDocumentsProvider but other DocumentsProviders will be also affected (we don't query them yet, but will face the same issue in the future). So another approach would be to allow ArcIntentHelper to obtain permission to any DocumentsProvider URIs from ArcFileSystemService by some means, e.g. sending intents.

Thanks for looping me in fukino@!

I agree that merging back to M67 seems risky. Let's test the fix out on M68 first. Quick question - Do the updates in M69 to make the Android files locally available change this interaction or is it unrelated?

Comment 6 by fukino@chromium.org, Jun 27 2018

Re:#5
The updates in M69 is unrelated to this issue.
This issue still reproduces with the same repro steps on ToT.
fukino@ - Just checking, I think this is the same as b/111288986 which is now Fixed?
Labels: -M-67
Status: Fixed (was: Started)
Yes, b/111288986 is the counter part of this issue and it is fixed now on M68+.

Sign in to add a comment