VDA unittest: Checking each decoded picture soundness by comparing md5sum |
||||
Issue descriptionVDA unittest renders each picture actually, lists these small thumbnails in one big image, computes md5sum of the image and compares to known md5sum values. This way has two problems; (1) A big image size is predetermined and small. So, when listing the thumbnails, frames at beginning of the stream is overwritten by ones around the end of stream. It doesn't check all the stream validness. (2) VDA unittest uses GPU for rendering. A resulted image depends on a platform and there is a need to prepare md5sum for several platforms. An alternative solution is to check yuv binary on each frame. The overall procedure is as follows; (1) Thumbnail test case should run in import-mode. This is because VDA unittest doesn't know file descriptors for pictures otherwise. (2) mmap each decoded picture and convert it to predetermined yuv layout by using libyuv. (3) Compute md5sum of the converted yuv binary and compare to a known md5sum value. In (2), to resolve differences by layout and alignment, we need to convert yuv returned from a driver to predetermined yuv layout by using libyuv. In (3), the converted yuv binary should be identical on any platform and thus we only have to prepare one set of single platforms. One pager: go/CrOSVFValidator
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9056f4eec66e651eca14dc7d4c461edcdeea37c3 commit 9056f4eec66e651eca14dc7d4c461edcdeea37c3 Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Aug 29 18:15:49 2018 video_VideoDecodeAccelerator: test IMPORT mode video_VideoDecodeAccelerator runs Chrome VDA unittest. VDA unittest tests ALLOCATE mode by default and has the option to test IMPORT mode, --test_import. video_VideoDecodeAccelerator should test not only ALLOCATE mode but also IMPORT mode. BUG= chromium:856562 TEST=video_VideoDecodeAccelerator at peach_pit Change-Id: I1e58382ac41feb4d6dc0da26b74e0e3874e141ed Reviewed-on: https://chromium-review.googlesource.com/1186391 Commit-Ready: Hirokazu Honda <hiroh@chromium.org> Tested-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Shuo-Peng Liao <deanliao@google.com> [modify] https://crrev.com/9056f4eec66e651eca14dc7d4c461edcdeea37c3/client/site_tests/video_VideoDecodeAccelerator/video_VideoDecodeAccelerator.py
,
Aug 31
,
Sep 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/dfd29495f8e67840de5acd28653e353c730ebc78 commit dfd29495f8e67840de5acd28653e353c730ebc78 Author: Hirokazu Honda <hiroh@chromium.org> Date: Sun Sep 02 14:19:04 2018 Revert "video_VideoDecodeAccelerator: test IMPORT mode" TBR=deanliao@google.com This reverts commit 9056f4eec66e651eca14dc7d4c461edcdeea37c3. Reason for revert: This CL cause test failures at some devices. Original change's description: > video_VideoDecodeAccelerator: test IMPORT mode > > video_VideoDecodeAccelerator runs Chrome VDA unittest. > VDA unittest tests ALLOCATE mode by default and has the option to test IMPORT > mode, --test_import. > video_VideoDecodeAccelerator should test not only ALLOCATE mode but also IMPORT > mode. > > BUG= chromium:856562 > TEST=video_VideoDecodeAccelerator at peach_pit > > Change-Id: I1e58382ac41feb4d6dc0da26b74e0e3874e141ed > Reviewed-on: https://chromium-review.googlesource.com/1186391 > Commit-Ready: Hirokazu Honda <hiroh@chromium.org> > Tested-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Shuo-Peng Liao <deanliao@google.com> Bug: chromium:856562 Change-Id: I0680e48494bb8e5b4ae5781a5beefd44836d99e7 Reviewed-on: https://chromium-review.googlesource.com/1200542 Commit-Ready: Hirokazu Honda <hiroh@chromium.org> Tested-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> [modify] https://crrev.com/dfd29495f8e67840de5acd28653e353c730ebc78/client/site_tests/video_VideoDecodeAccelerator/video_VideoDecodeAccelerator.py
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7578a6944fd143eb096ff3a68639b6d328bf6d37 commit 7578a6944fd143eb096ff3a68639b6d328bf6d37 Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Sep 05 00:30:08 2018 Revert "video_VideoDecodeAccelerator: test IMPORT mode" TBR=deanliao@google.com This reverts commit 9056f4eec66e651eca14dc7d4c461edcdeea37c3. Reason for revert: This CL cause test failures at some devices. Original change's description: > video_VideoDecodeAccelerator: test IMPORT mode > > video_VideoDecodeAccelerator runs Chrome VDA unittest. > VDA unittest tests ALLOCATE mode by default and has the option to test IMPORT > mode, --test_import. > video_VideoDecodeAccelerator should test not only ALLOCATE mode but also IMPORT > mode. > > BUG= chromium:856562 > TEST=video_VideoDecodeAccelerator at peach_pit > > Change-Id: I1e58382ac41feb4d6dc0da26b74e0e3874e141ed > Reviewed-on: https://chromium-review.googlesource.com/1186391 > Commit-Ready: Hirokazu Honda <hiroh@chromium.org> > Tested-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Shuo-Peng Liao <deanliao@google.com> Bug: chromium:856562 Change-Id: I0680e48494bb8e5b4ae5781a5beefd44836d99e7 Reviewed-on: https://chromium-review.googlesource.com/1200542 Commit-Ready: Hirokazu Honda <hiroh@chromium.org> Tested-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> (cherry picked from commit dfd29495f8e67840de5acd28653e353c730ebc78) Reviewed-on: https://chromium-review.googlesource.com/1205930 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Trybot-Ready: Hirokazu Honda <hiroh@chromium.org> [modify] https://crrev.com/7578a6944fd143eb096ff3a68639b6d328bf6d37/client/site_tests/video_VideoDecodeAccelerator/video_VideoDecodeAccelerator.py
,
Sep 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76f221244448793c3ab0346bc94e77e8d5a3b666 commit 76f221244448793c3ab0346bc94e77e8d5a3b666 Author: Hirokazu Honda <hiroh@chromium.org> Date: Tue Sep 11 08:54:27 2018 VideoFrameLayout: Add offsets and aggregate strides and offsets as Plane VideoFrameLayout should have information about offset per plane, not only stride. The number of stride should be the same as the number of offsets. To guarantee this, they are stored in the vector of struct, Plane. BUG= chromium:876986 , chromium:856562 TEST=VDA unittest and media_unittest Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie9d9afa5db7dabaee2f48fbcd355c13d29be8035 Reviewed-on: https://chromium-review.googlesource.com/1188730 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#590242} [modify] https://crrev.com/76f221244448793c3ab0346bc94e77e8d5a3b666/media/base/video_frame.cc [modify] https://crrev.com/76f221244448793c3ab0346bc94e77e8d5a3b666/media/base/video_frame.h [modify] https://crrev.com/76f221244448793c3ab0346bc94e77e8d5a3b666/media/base/video_frame_layout.cc [modify] https://crrev.com/76f221244448793c3ab0346bc94e77e8d5a3b666/media/base/video_frame_layout.h [modify] https://crrev.com/76f221244448793c3ab0346bc94e77e8d5a3b666/media/base/video_frame_layout_unittest.cc [modify] https://crrev.com/76f221244448793c3ab0346bc94e77e8d5a3b666/media/base/video_frame_unittest.cc [modify] https://crrev.com/76f221244448793c3ab0346bc94e77e8d5a3b666/media/cast/test/utility/video_utility.cc [modify] https://crrev.com/76f221244448793c3ab0346bc94e77e8d5a3b666/media/gpu/v4l2/v4l2_image_processor.cc [modify] https://crrev.com/76f221244448793c3ab0346bc94e77e8d5a3b666/media/gpu/v4l2/v4l2_video_decode_accelerator.cc
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3085d5e5988b47d48f2a1ceddff84e8dc23081d commit d3085d5e5988b47d48f2a1ceddff84e8dc23081d Author: Hirokazu Honda <hiroh@chromium.org> Date: Thu Oct 18 13:25:56 2018 media/test/data: Add golden md5 values on decoded videos frame in VDA unittest test-25fps.*.frames.md5 contains the golden md5 values on decoded video frames in VDA unittest. These values must be identical on any platforms. BUG= chromium:856562 TEST=VDA unittest at eve, veyron_minnie, hana Change-Id: I3c63b92dcc52b8a3a6cc1dc4a2dd9e9147e5ec7b Reviewed-on: https://chromium-review.googlesource.com/c/1172271 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#600744} [modify] https://crrev.com/d3085d5e5988b47d48f2a1ceddff84e8dc23081d/media/test/data/README.md [add] https://crrev.com/d3085d5e5988b47d48f2a1ceddff84e8dc23081d/media/test/data/test-25fps.h264.frames.md5 [add] https://crrev.com/d3085d5e5988b47d48f2a1ceddff84e8dc23081d/media/test/data/test-25fps.vp8.frames.md5 [add] https://crrev.com/d3085d5e5988b47d48f2a1ceddff84e8dc23081d/media/test/data/test-25fps.vp9.frames.md5 [add] https://crrev.com/d3085d5e5988b47d48f2a1ceddff84e8dc23081d/media/test/data/test-25fps.vp9_2.frames.md5
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adc481c949966c570fbbfb67cab52bc15c6e5324 commit adc481c949966c570fbbfb67cab52bc15c6e5324 Author: Hirokazu Honda <hiroh@chromium.org> Date: Fri Oct 19 17:45:46 2018 media/gpu/test VideoFrameValidator: Compare each decoded picture (yuv) with golden md5 Decoded pictures (i.e. yuv format) on h264, vp8 and vp9 must be identical on any platforms, except its pixel format and device alignment. VideoFrameValidator checks soundness of each decoded picture comparing its md5sum value with golden md5sum. VideoFrameMapper used by VideoFrameValidator map decoded pictures and converts them, by libyuv, to I420 picture to resolve pixel format and device alignment differences. This change is the first step for it. VideoFrameValidator would support non tiled buffers. BUG= chromium:856562 TEST=VDA unittest on h264, vp8 and vp9 with --frame_validator at veyron_minnie and kevin, $ ./video_decode_accelerator_unittest --test_video_data=test-25fps.vp8:320:240:250:250:35:150:11 --ozone-platform=gbm --gtest_filter=Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 --test_import --frame_validator Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iddd284bd47b2a5bb9921dc8d54f9d77ed694f5ad Reviewed-on: https://chromium-review.googlesource.com/c/1172266 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#601216} [modify] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/BUILD.gn [add] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/test/generic_dmabuf_video_frame_mapper.cc [add] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/test/generic_dmabuf_video_frame_mapper.h [modify] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/test/video_decode_accelerator_unittest_helpers.cc [modify] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/test/video_decode_accelerator_unittest_helpers.h [add] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/test/video_frame_mapper.h [add] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/test/video_frame_mapper_factory.cc [add] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/test/video_frame_mapper_factory.h [add] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/test/video_frame_validator.cc [add] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/test/video_frame_validator.h [modify] https://crrev.com/adc481c949966c570fbbfb67cab52bc15c6e5324/media/gpu/video_decode_accelerator_unittest.cc
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54e6213a835bf0778701da3075a8a0996793faad commit 54e6213a835bf0778701da3075a8a0996793faad Author: Hirokazu Honda <hiroh@chromium.org> Date: Mon Oct 29 10:24:33 2018 media/gpu/test VideoFrameValidator: Support VA-API based VDA Decoded pictures (i.e. yuv format) on h264, vp8 and vp9 must be identical on any platforms, except its pixel format and device alignment. VideoFrameValidator checks soundness of each decoded picture comparing its md5sum value with golden md5sum. VideoFrameMapper used by VideoFrameValidator map decoded pictures and converts them, by libyuv, to I420 picture to resolve pixel format and device alignment differences. This change is the second step for it. VideoFrameValidator would support VA-API based VDA after this change. One pager: go/CrOSVFValidator BUG= chromium:856562 TEST=VDA unittest on h264, vp8 and vp9 with --frame_validator at eve $ ./video_decode_accelerator_unittest --test_video_data=test-25fps.vp8:320:240:250:250:35:150:11 --ozone-platform=gbm --gtest_filter=Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 --test_import --frame_validator Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I63b57cb35553edea0a85ea4aab5017f031653d82 Reviewed-on: https://chromium-review.googlesource.com/c/1189511 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#603448} [modify] https://crrev.com/54e6213a835bf0778701da3075a8a0996793faad/media/gpu/BUILD.gn [add] https://crrev.com/54e6213a835bf0778701da3075a8a0996793faad/media/gpu/test/vaapi_dmabuf_video_frame_mapper.cc [add] https://crrev.com/54e6213a835bf0778701da3075a8a0996793faad/media/gpu/test/vaapi_dmabuf_video_frame_mapper.h [modify] https://crrev.com/54e6213a835bf0778701da3075a8a0996793faad/media/gpu/test/video_frame_mapper.h [modify] https://crrev.com/54e6213a835bf0778701da3075a8a0996793faad/media/gpu/test/video_frame_mapper_factory.cc [modify] https://crrev.com/54e6213a835bf0778701da3075a8a0996793faad/media/gpu/test/video_frame_mapper_factory.h [modify] https://crrev.com/54e6213a835bf0778701da3075a8a0996793faad/media/gpu/test/video_frame_validator.h
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/090f680bfcf931f40377d1946645a6f6a5fd29d5 commit 090f680bfcf931f40377d1946645a6f6a5fd29d5 Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Oct 31 06:29:08 2018 media/gpu/VDA unittest: Enable video frame validator in evey TestSimpleDecode test case This enables VideoFrameValidator in evey TestSimpleDecode test case, that is, the test case except TestDecodeTimeMedia (performance test) and NoCrash. Because an input stream is decoded repeatedly, the index in display order of video frame on PictureReady() needs to be passed to VideoFrameValidator. It seems there is no good way to get the frame index from Picture. So I just count up the index on PictureReady() and reset it to 0 on NotifyResetDone(). This seems a hacky way and only works with the current VDA unittest, which always rewind to the beginning of the stream and does not jump to the middle of the stream. BUG= chromium:856562 TEST=VDA unittest on eve with frame validator $ ./video_decode_accelerator_unittest --test_video_data=test-25fps.h264:320:240:250:258:35:150:1 --ozone-platform=gbm --test_import --frame_validator Change-Id: I8fbbf165254f4e26c69f8da27b41ff3b9f395224 Reviewed-on: https://chromium-review.googlesource.com/c/1304286 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#604171} [modify] https://crrev.com/090f680bfcf931f40377d1946645a6f6a5fd29d5/media/gpu/test/video_frame_validator.cc [modify] https://crrev.com/090f680bfcf931f40377d1946645a6f6a5fd29d5/media/gpu/test/video_frame_validator.h [modify] https://crrev.com/090f680bfcf931f40377d1946645a6f6a5fd29d5/media/gpu/video_decode_accelerator_unittest.cc
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/363196e1416bdae71a56fc10b70a18755e64580d commit 363196e1416bdae71a56fc10b70a18755e64580d Author: Hirokazu Honda <hiroh@chromium.org> Date: Fri Nov 02 07:25:52 2018 media/gpu/test/VaapiDmabufVFMapper: Don't perform format conversion in VFMapper VaapiDmabufVideoFrameMapper does format conversion to I420. This is not good from design perspective as VFMapper should map a buffer as it is. This eliminates the format conversion from VaapiDmabufVFMapper. BUG= chromium:856562 TEST=VDA unittest --test_import --frame_validator Change-Id: Ic5e12e7875a9bb91ca2e21fc50c2de3a1d913199 Reviewed-on: https://chromium-review.googlesource.com/c/1312440 Reviewed-by: Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604859} [modify] https://crrev.com/363196e1416bdae71a56fc10b70a18755e64580d/media/gpu/test/vaapi_dmabuf_video_frame_mapper.cc [modify] https://crrev.com/363196e1416bdae71a56fc10b70a18755e64580d/media/gpu/test/video_frame_validator.cc
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/676790d07c105bcc8f83ffd27b3d00ea385f6c66 commit 676790d07c105bcc8f83ffd27b3d00ea385f6c66 Author: Hirokazu Honda <hiroh@chromium.org> Date: Tue Nov 06 05:07:58 2018 media/gpu/VDA unittest: Add command line option for VideoFrameValidator flags This adds video frame flags, --frame_validator=, check : compares md5 values computed from video frame with the expected md5 values. Test fails if there is an unexpected video frame. dump : outputs video frames to files BUG= chromium:856562 TEST=VDA unittest with --test_import TEST=VDA unittest with --test_import --frame_validator=check TEST=VDA unittest with --frame_validator=check TEST=VDA unittest with --frame_validator=check,dump TEST=VDA unittest with --frame_validator=dump TEST=VDA unittest with --gtest_filter=VideoDecodeAcceleratorTest.DISABLED_GenMD5 --gtest_also_run_disabled_tests Change-Id: I1511ef07a2bd01231e9daf1038776324c22e3da5 Reviewed-on: https://chromium-review.googlesource.com/c/1309390 Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605598} [modify] https://crrev.com/676790d07c105bcc8f83ffd27b3d00ea385f6c66/media/gpu/test/video_frame_validator.cc [modify] https://crrev.com/676790d07c105bcc8f83ffd27b3d00ea385f6c66/media/gpu/test/video_frame_validator.h [modify] https://crrev.com/676790d07c105bcc8f83ffd27b3d00ea385f6c66/media/gpu/video_decode_accelerator_unittest.cc
,
Nov 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5a81e0c668ca2256aa482318d75bd023ba5d8382 commit 5a81e0c668ca2256aa482318d75bd023ba5d8382 Author: Hirokazu Honda <hiroh@chromium.org> Date: Sun Nov 18 15:11:07 2018 video_VideoDecodeAccelerator: Add test cases to run VDA unittest with IMPORT mode VDA unittest can run with either ALLOCATE or IMPORT mode. The existing test cases all run with ALLOCATE mode. This adds the test case to run IMPORT mode. We enable VideoFrameValidator with IMPORT mode, which checks soundness of video decoded frames in VDA unittest. It is infeasible to let VDA unittest run with IMPORT mode on some devices, https://crbug.com/881729 . They are the devices where ARC++ is disabled. So I set DEPENDENCIES to "arc" in order to not run on them. BUG= chromium:856562 TEST=video_VideoDecodeAccelerator.h264.import Change-Id: I1cc1b8a7acd1d671d517b3f2c3071287a7d49860 Reviewed-on: https://chromium-review.googlesource.com/1331194 Commit-Ready: Hirokazu Honda <hiroh@chromium.org> Tested-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> [add] https://crrev.com/5a81e0c668ca2256aa482318d75bd023ba5d8382/client/site_tests/video_VideoDecodeAccelerator/control.vp8.import [modify] https://crrev.com/5a81e0c668ca2256aa482318d75bd023ba5d8382/client/site_tests/video_VideoDecodeAccelerator/video_VideoDecodeAccelerator.py [add] https://crrev.com/5a81e0c668ca2256aa482318d75bd023ba5d8382/client/site_tests/video_VideoDecodeAccelerator/control.vp9_2.import [add] https://crrev.com/5a81e0c668ca2256aa482318d75bd023ba5d8382/client/site_tests/video_VideoDecodeAccelerator/control.h264.import [add] https://crrev.com/5a81e0c668ca2256aa482318d75bd023ba5d8382/client/site_tests/video_VideoDecodeAccelerator/control.vp9.import
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db2bf67573cc0ff295f995e5746eb7516df0d26e commit db2bf67573cc0ff295f995e5746eb7516df0d26e Author: Hirokazu Honda <hiroh@chromium.org> Date: Tue Nov 20 00:13:16 2018 GenericDmaBufVideoFrameValidator: Map YV12 VideoFrame as-is GenericDmaBufVideoFrameValidator swaps U plane and V plane addresses so that VideoFrameValidator is able to libyuv::I420Copy in the order Y, U and V. This is a wrong design, meaning VideoFrameMapper does not only map but also does something. VideoFrameMapper caller should expect the address acquired by VideoFrame::data(UPlane) is V plane's and one by VideoFrame::data(VPlane) is U plane's in the case of YV12 VideoFrame. BUG= chromium:895230 , chromium:856562 TEST=VDA unittest on hana with --frame_validator=check TEST=VEA unittest on hana with --native_input Change-Id: Ibf5e5685d95634fe6720f07dc154fd01907516d8 Reviewed-on: https://chromium-review.googlesource.com/c/1341783 Reviewed-by: Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#609518} [modify] https://crrev.com/db2bf67573cc0ff295f995e5746eb7516df0d26e/media/gpu/test/generic_dmabuf_video_frame_mapper.cc [modify] https://crrev.com/db2bf67573cc0ff295f995e5746eb7516df0d26e/media/gpu/test/video_frame_validator.cc
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12f41e49ec7aea3108bd0a7d079e27da6ea6fe98 commit 12f41e49ec7aea3108bd0a7d079e27da6ea6fe98 Author: Hirokazu Honda <hiroh@chromium.org> Date: Tue Nov 20 02:58:34 2018 media/gpu/VDA unittest: Fix wrong USE_VAAPI macro This wrong macro causes GenericDmaBufVideoFrameValidator is used on intel platform. Due to it, VDA unittest with frame validator fails on intel platform. BUG= chromium:856562 TEST=VDA unittest --frame_validator=check on eve Change-Id: Iad1749ea4ada09a9d01b92137ca10c3215d9893d Reviewed-on: https://chromium-review.googlesource.com/c/1343404 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#609577} [modify] https://crrev.com/12f41e49ec7aea3108bd0a7d079e27da6ea6fe98/media/gpu/video_decode_accelerator_unittest.cc
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/965840d0d5e6ba9c54694f1215251e1958c75974 commit 965840d0d5e6ba9c54694f1215251e1958c75974 Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Nov 21 02:27:38 2018 video_VideoDecodeAccelerator: Remove multiple DEPENDENCIES in *.import The first DEPENDENCIES = "arc" is overwritten by the last DEPENDENCIES = "cleanup-reboot". This causes those tests run on non arc++ enabled platform. BUG= chromium:856562 TEST=video_VideoDecodeAccelerator.h264.import Change-Id: I5b192a6e9fed5390797da7f345345980a86fee1c Reviewed-on: https://chromium-review.googlesource.com/1343620 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Tomasz Figa <tfiga@chromium.org> [modify] https://crrev.com/965840d0d5e6ba9c54694f1215251e1958c75974/client/site_tests/video_VideoDecodeAccelerator/control.vp8.import [modify] https://crrev.com/965840d0d5e6ba9c54694f1215251e1958c75974/client/site_tests/video_VideoDecodeAccelerator/control.vp9_2.import [modify] https://crrev.com/965840d0d5e6ba9c54694f1215251e1958c75974/client/site_tests/video_VideoDecodeAccelerator/control.h264.import [modify] https://crrev.com/965840d0d5e6ba9c54694f1215251e1958c75974/client/site_tests/video_VideoDecodeAccelerator/control.vp9.import
,
Nov 29
All necessary CLs are submitted. Closed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by deanliao@chromium.org
, Aug 23