Issue metadata
Sign in to add a comment
|
[Mac views] Blue focus is seen at 'X' icon of a tab while moving tabs on chrome |
||||||||||||||||||||||||
Issue descriptionChrome Version: Version 69.0.3473.0 OS: MacOS 10.13.4 What steps will reproduce the problem? (1) Enable 'Use Views browser windows instead of Cocoa.' in about://flags (2) Relaunch chrome (3) Open multiple tabs (Gmail, youtube, wikipedia...) on same Window (4) Now try to move tab from one place to other place and observe blue focus on 'X' icon of a tab What is the expected result? No blue focus should be seen at 'X' icon of a tab while moving tabs on chrome What happens instead? Blue focus is seen at 'X'icon of a tab while moving tabs on chrome Screencast attached for reference. Thanks..!
,
Jun 26 2018
,
Jun 28 2018
,
Jun 29 2018
I'll take a look.
,
Jun 29 2018
This is only on Mac because only Mac has FocusManager::keyboard_accessible_ == true. https://cs.chromium.org/chromium/src/ui/views/focus/focus_manager.cc?q=FocusManager&sq=package:chromium&dr=CSs&l=566
,
Jun 29 2018
This CL fixes the bug by making the tabs themselves focusable: https://chromium-review.googlesource.com/c/chromium/src/+/1121349 After the above, we should do a followup CL that: 1. Draws some visual indication that the tab itself is focused 2. Make the tab itself respond to keyboard Space to activate the tab.
,
Jul 2
,
Jul 12
,
Jul 12
,
Jul 12
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jmukthavaram@chromium.org
, Jun 26 2018