New issue
Advanced search Search tips

Issue 856548 link

Starred by 2 users
Status: Fixed
Owner:
olivierrobin@chromium.org
Closed: Oct 15
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Presubmit warning: check wants to put + in C++ guard

Project Member Reported by olivierrobin@chromium.org, Jun 26 2018 
** Presubmit Warnings **
Header using the wrong include guard name IOS_CHROME_COMMON_FAVICON_FAVICON_ATTRIBUTES_PRIVATE_H_
  ios/chrome/common/favicon/favicon_attributes+private.h:5

***************
Expected: 'IOS_CHROME_COMMON_FAVICON_FAVICON_ATTRIBUTES+PRIVATE_H_'
Found: u'IOS_CHROME_COMMON_FAVICON_FAVICON_ATTRIBUTES_PRIVATE_H_'
***************


but having plus in defines does not compile.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bba13749c8462ce2149045a13ad81e1b2dbe347c

commit bba13749c8462ce2149045a13ad81e1b2dbe347c
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Mon Jul 30 11:31:34 2018

[Presubmit] When checking include guards, replace + with _.

+ is an invalid character for include guard, so for a file
named "foo+bar.h", include guard should be FOO_BAR_H_

Bug:  856548 
Change-Id: I39a2d01e328b9352620d0d0e9548e40f1b57150a
Reviewed-on: https://chromium-review.googlesource.com/1152971
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579010}
[modify] https://crrev.com/bba13749c8462ce2149045a13ad81e1b2dbe347c/PRESUBMIT.py
[modify] https://crrev.com/bba13749c8462ce2149045a13ad81e1b2dbe347c/PRESUBMIT_test.py

Comment 2 by pkl@chromium.org, Jul 30

Owner: olivierrobin@chromium.org
Status: Assigned (was: Untriaged)
Is your fix in comment 1 sufficient for this to be marked as "Fixed"?

Comment 3 by olivierrobin@chromium.org, Oct 15

Status: Fixed (was: Assigned)
►

Sign in to add a comment