New issue
Advanced search Search tips

Issue 856538 link

Starred by 1 user
Status: Fixed
Owner:
jochen@chromium.org
Closed: Jul 18
Cc:
blundell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 806774
Blocking:
issue 796544
issue 797949



Sign in to add a comment

migrate ChromeCryptAuthService to IdentityManager

Project Member Reported by jochen@chromium.org, Jun 26 2018 
Currently it uses SigninManager, and ProfileOAuth2TokenService.

The main challenge is that it currently waits for a refresh token to be available, which is not readily available as a signal from the identity manager.

Comment 1 by blundell@chromium.org, Jun 27 2018

Status: Available (was: Untriaged)
Thanks, Jochen! As of quite recently there is this observer callback: https://cs.chromium.org/chromium/src/services/identity/public/cpp/identity_manager.h?q=identity_manager.h&sq=package:chromium&dr=CSs&l=79

Is that sufficient for this use case?

Comment 2 by jochen@chromium.org, Jun 27 2018 

you'd still need an api where you can ask whether right now one is available, or whether you need to wait for the callback

Comment 3 by blundell@chromium.org, Jun 28 2018

Blockedon: 806744

Comment 4 by blundell@chromium.org, Jun 28 2018 

Thanks! That API should be available soon (https://chromium-review.googlesource.com/c/chromium/src/+/1098668).

Comment 5 by sigurds@chromium.org, Jun 28 2018 

Wrong blocked-on bug number?

Comment 6 by blundell@chromium.org, Jun 28 2018

Blockedon: -806744 806774
thanks!

Comment 7 by blundell@chromium.org, Jul 2

Owner: jochen@chromium.org
Status: Assigned (was: Available)
Hey Jochen,

Do you want to take another crack at this now?

Thanks,

Colin

Comment 8 by jochen@chromium.org, Jul 18

Status: Fixed (was: Assigned)
landed in https://chromium.googlesource.com/chromium/src.git/+/6896f144b18afb1b1cb12957748bbdd9edb8a6d2 but I accidentially put the wrong issue number in the CL description..
►

Sign in to add a comment