New issue
Advanced search Search tips

Issue 856531 link

Starred by 1 user
Status: Verified
Owner:
hongchan@chromium.org
Closed: Jul 2
Cc:
maxmorin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 856690


Sign in to add a comment

Printing AudioContext after close DCHECKs.

Project Member Reported by maxmorin@chromium.org, Jun 26 2018 
In Devtools:
ac = new AudioContext()
ac.close()
ac

crashes. It can also be reproed by putting <body><script>ac = new AudioContext(); ac.close(); ac.baseLatency;</script></body>
in an html file and loading it into Chrome.

Comment 1 by maxmorin@chromium.org, Jun 26 2018 

I should add the stack trace.

[1:1:0626/101804.245241:FATAL:audio_context.cc(316)] Check failed: destination(). 
#0 0x7fa75ec2244d base::debug::StackTrace::StackTrace()
#1 0x7fa75e96836c base::debug::StackTrace::StackTrace()
#2 0x7fa75e9d73aa logging::LogMessage::~LogMessage()
#3 0x7fa74251bb28 blink::AudioContext::baseLatency()
#4 0x7fa741cf0da3 blink::AudioContextV8Internal::baseLatencyAttributeGetter()
#5 0x7fa741cf0d3a blink::V8AudioContext::baseLatencyAttributeGetterCallback()
#6 0x7fa74837e034 v8::internal::FunctionCallbackArguments::Call()
#7 0x7fa74837c3c1 v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#8 0x7fa74837b0f5 v8::internal::Builtins::InvokeApiFunction()
#9 0x7fa748944ddb v8::internal::Object::GetPropertyWithAccessor()
#10 0x7fa748831753 v8::internal::LoadIC::Load()
#11 0x7fa748840497 v8::internal::__RT_impl_Runtime_LoadIC_Miss()
#12 0x7fa749045db5 <unknown>

Comment 2 by rtoy@chromium.org, Jun 26 2018 

Heh.  This is most likely caused by the fact that when the context is closed, we remove the destination node which has the baseLatency stuff.  We should not remove the destination node.  (There's a bug filed on that somewhere.)

Comment 3 by hongchan@chromium.org, Jun 26 2018

Blockedon: 856690

Comment 4 by hongchan@chromium.org, Jun 29 2018 

I believe this is also fixed by:
https://chromium-review.googlesource.com/c/chromium/src/+/1115516

Will verify it soon.

Comment 5 by hongchan@chromium.org, Jul 2

Status: Verified (was: Assigned)
Verified with Version 69.0.3480.0 (Developer Build) (64-bit)

The repro code in the description doesn't crash anymore.
►

Sign in to add a comment