New issue
Advanced search Search tips

Issue 856530 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 803774



Sign in to add a comment

Signed Exchange: Replace "htxg" in the codebase with "sxg"

Project Member Reported by ksakamoto@chromium.org, Jun 26 2018

Issue description

The name "htxg" is a leftover from a time when the old format of http exchange (application/http-exchange+cbor) was used.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba390859a2f5b21510b8808915d57afe22317a75

commit ba390859a2f5b21510b8808915d57afe22317a75
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed Jul 11 01:08:55 2018

Rename content/test/data/htxg to content/test/data/sxg

Bug:  856530 
Change-Id: I8da043903712003379603b443ad2c584ebc1c244
Reviewed-on: https://chromium-review.googlesource.com/1131022
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574024}
[modify] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/WATCHLISTS
[modify] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/browser/web_package/signed_exchange_certificate_chain_unittest.cc
[modify] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/browser/web_package/signed_exchange_envelope_unittest.cc
[modify] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/.gitattributes
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/127.0.0.1.public.pem.cbor
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/404.msg
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/404.msg.mock-http-headers
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/README
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/hello.txt
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/prime256v1-sha256-noext.public.pem
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/prime256v1-sha256.csr
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/prime256v1-sha256.public.pem
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/prime256v1.key
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/secp384r1-sha256.csr
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/secp384r1-sha256.public.pem
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/secp384r1.key
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.com_invalid_test.htxg
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.com_invalid_test.htxg.mock-http-headers
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.org-noext.public.pem.cbor
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.org.public.pem.cbor
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.org.public.pem.cbor.mock-http-headers
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.org_hello.txt.htxg
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.org_noext_test.htxg
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.org_test.htxg
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.org_test.htxg.mock-http-headers
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.org_test_invalid_content_type.htxg
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.example.org_test_invalid_content_type.htxg.mock-http-headers
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/test.html
[rename] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/data/sxg/x509.ext
[modify] https://crrev.com/ba390859a2f5b21510b8808915d57afe22317a75/content/test/fuzzer/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00040e595d25499533dc329164dc3f0964c024fe

commit 00040e595d25499533dc329164dc3f0964c024fe
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed Jul 11 01:15:55 2018

Replace "htxg" in content/ with "sxg"

Bug:  856530 
Change-Id: I21c938052ca9493408947b2e5d50b43806f05104
Reviewed-on: https://chromium-review.googlesource.com/1131047
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574026}
[modify] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/browser/loader/prefetch_browsertest.cc
[modify] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
[modify] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/browser/web_package/signed_exchange_envelope_unittest.cc
[modify] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/browser/web_package/signed_exchange_handler_unittest.cc
[modify] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/test/data/sxg/.gitattributes
[modify] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/test/data/sxg/README
[rename] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/test/data/sxg/test.example.com_invalid_test.sxg
[rename] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/test/data/sxg/test.example.com_invalid_test.sxg.mock-http-headers
[rename] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/test/data/sxg/test.example.org_hello.txt.sxg
[rename] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/test/data/sxg/test.example.org_noext_test.sxg
[rename] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/test/data/sxg/test.example.org_test.sxg
[rename] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/test/data/sxg/test.example.org_test.sxg.mock-http-headers
[rename] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/test/data/sxg/test.example.org_test_invalid_content_type.sxg
[rename] https://crrev.com/00040e595d25499533dc329164dc3f0964c024fe/content/test/data/sxg/test.example.org_test_invalid_content_type.sxg.mock-http-headers

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c797a4c5598a451206e52947cefb604d0b5a09f5

commit c797a4c5598a451206e52947cefb604d0b5a09f5
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed Jul 11 07:36:43 2018

Replace "htxg" in layout tests with "sxg"

This completes the htxg -> sxg renaming.

Bug:  856530 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Idf5243b0ff08acc761313299415bcb7fa32b333d
Reviewed-on: https://chromium-review.googlesource.com/1132835
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574101}
[modify] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/07d2a0beb901b531f9b7508bcc2e054668bd1624/third_party/WebKit/LayoutTests/http/tests/devtools/htxg/htxg-disable-cache-expected.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-cert-not-found-expected.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-cert-not-found.js
[add] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-disable-cache-expected.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-disable-cache.js
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-navigation-expected.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-navigation-expired-expected.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-navigation-expired.js
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-navigation.js
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-prefetch-expected.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-prefetch-expired-expected.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-prefetch-expired.js
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/devtools/sxg/sxg-prefetch.js
[delete] https://crrev.com/07d2a0beb901b531f9b7508bcc2e054668bd1624/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-cert-not-found.sxg
[delete] https://crrev.com/07d2a0beb901b531f9b7508bcc2e054668bd1624/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-invalid-validity-url.sxg
[delete] https://crrev.com/07d2a0beb901b531f9b7508bcc2e054668bd1624/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location.sxg
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/README.md
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/.htaccess
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/127.0.0.1.pem.cbor
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/127.0.0.1.sxg.pem.cbor
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/README.md
[add] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-cert-not-found.sxg
[add] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-invalid-validity-url.sxg
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location-origin-trial.php
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location.html
[add] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location.sxg
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-util.js
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-double-prefetch.html
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-expired.html
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-invalid-validity-url.html
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-location-origin-trial.html
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-location.html
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-non-secure-origin.html
[delete] https://crrev.com/07d2a0beb901b531f9b7508bcc2e054668bd1624/third_party/WebKit/LayoutTests/virtual/htxg-origin-trial/http/tests/loading/htxg/htxg-location-expected.txt
[delete] https://crrev.com/07d2a0beb901b531f9b7508bcc2e054668bd1624/third_party/WebKit/LayoutTests/virtual/htxg-with-network-service/http/tests/loading/htxg/README.txt
[delete] https://crrev.com/07d2a0beb901b531f9b7508bcc2e054668bd1624/third_party/WebKit/LayoutTests/virtual/htxg/http/tests/loading/htxg/README.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/README.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/sxg-location-expected.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial/http/tests/loading/sxg/README.txt
[copy] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial/http/tests/loading/sxg/sxg-location-expected.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/virtual/sxg-with-network-service/http/tests/devtools/sxg/README.txt
[copy] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/virtual/sxg-with-network-service/http/tests/loading/sxg/README.txt
[rename] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/devtools/sxg/README.txt
[copy] https://crrev.com/c797a4c5598a451206e52947cefb604d0b5a09f5/third_party/WebKit/LayoutTests/virtual/sxg/http/tests/loading/sxg/README.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e72dce733afafe0340e25390b5f4c228702e9de

commit 7e72dce733afafe0340e25390b5f4c228702e9de
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Jul 12 03:42:12 2018

Update signed exchange test directory reference

The directory was renamed in crrev.com/c/1132835.

Bug:  856530 
Change-Id: I34890b24f256048d49bc59f5ba34ec048ce48d1c
Reviewed-on: https://chromium-review.googlesource.com/1133609
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574481}
[modify] https://crrev.com/7e72dce733afafe0340e25390b5f4c228702e9de/third_party/blink/tools/blinkpy/third_party/wpt/README.chromium

Status: Fixed (was: Available)

Sign in to add a comment