New issue
Advanced search Search tips

Issue 856527 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 857295



Sign in to add a comment

Support the memory pressure handler in CC

Project Member Reported by gyuyoung...@chromium.org, Jun 26 2018

Issue description

In CC there are 4 classes to implement the memory coordinator. However, the memory coordinator is not enabled by default. To help low-end devices or embedders, it would be good if we support the memory pressure handler until the memory coordinator is enabled by default.
 
Status: Started (was: Untriaged)
Blocking: 857295
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3672278287eed00aedf1971d114d81bdf8e470d2

commit 3672278287eed00aedf1971d114d81bdf8e470d2
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Sat Jun 30 03:11:31 2018

CC: Support the memory pressure handler in StagingBufferPool

StagingBufferPool has been only supporting the MemoryCoordinator.
However, it is not enabled by default. So it would be good if we
support the memory pressure handler until the MemoryCoordinator
is enabled by default. Especially, it will help low-end devices to
reduce memory usage under the out-of-memory situation.

Bug:  856527 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I52be2b732199c66ddaac015fb29aae274ff2fb1d
Reviewed-on: https://chromium-review.googlesource.com/1114559
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571750}
[modify] https://crrev.com/3672278287eed00aedf1971d114d81bdf8e470d2/cc/raster/staging_buffer_pool.cc
[modify] https://crrev.com/3672278287eed00aedf1971d114d81bdf8e470d2/cc/raster/staging_buffer_pool.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6db6bb14d75637ca994218de6e542e0b086a9b3d

commit 6db6bb14d75637ca994218de6e542e0b086a9b3d
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Tue Jul 03 07:40:34 2018

CC: Support the memory pressure handler in ResourcePool

As StagingbufferPool, ResourcePool has been only supporting the
MemoryCoordinator. However, it is not enabled by default. So it
would be good if we support the memory pressure handler until the
MemoryCoordinator is enabled by default. Especially, it will help
low-end devices to reduce memory usage under the out-of-memory situation.

Bug:  856527 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I070e71c3d39da61b56f2b11d51bf5efdf1ac3c7c
Reviewed-on: https://chromium-review.googlesource.com/1121949
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#572137}
[modify] https://crrev.com/6db6bb14d75637ca994218de6e542e0b086a9b3d/cc/resources/resource_pool.cc
[modify] https://crrev.com/6db6bb14d75637ca994218de6e542e0b086a9b3d/cc/resources/resource_pool.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/841094569d6e5bd8a440c3c170ee71e2a22648d8

commit 841094569d6e5bd8a440c3c170ee71e2a22648d8
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Tue Jul 03 09:03:16 2018

CC: Support the memory pressure handler in SoftwareImageDecodeCache

As StagingbufferPool and ResourcePool, SoftwareImageDecodeCache has been
only supporting the MemoryCoordinator. However, it is not enabled by
default. So it would be good if we support the memory pressure handler
until the MemoryCoordinator is enabled by default. Especially, it will
help low-end devices to reduce memory usage under the out-of-memory
situation.

Bug:  856527 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0aace1839b9d0e056f1a2db18f5d9e652c742c5f
Reviewed-on: https://chromium-review.googlesource.com/1122016
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#572154}
[modify] https://crrev.com/841094569d6e5bd8a440c3c170ee71e2a22648d8/cc/tiles/software_image_decode_cache.cc
[modify] https://crrev.com/841094569d6e5bd8a440c3c170ee71e2a22648d8/cc/tiles/software_image_decode_cache.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e54813bda8dfa082a5c940904e3a8b6df341c067

commit e54813bda8dfa082a5c940904e3a8b6df341c067
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Tue Jul 10 01:21:52 2018

CC: Support the memory pressure handler in GpuImageDecodeCache

As StagingbufferPool and ResourcePool, GpuImageDecodeCache has been
only supporting the MemoryCoordinator. However, it is not enabled by
default. So it would be good if we support the memory pressure handler
until the MemoryCoordinator is enabled by default. Especially, it will
help low-end devices to reduce memory usage under the out-of-memory
situation.

Bug:  856527 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I564051a4fa65b34fa9c14c72e626000e603eb865
Reviewed-on: https://chromium-review.googlesource.com/1121952
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#573584}
[modify] https://crrev.com/e54813bda8dfa082a5c940904e3a8b6df341c067/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/e54813bda8dfa082a5c940904e3a8b6df341c067/cc/tiles/gpu_image_decode_cache.h

Status: Fixed (was: Started)
I think I've completed this work. Closed.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f05b8f9d363e227639aad006ef51e997a1d62187

commit f05b8f9d363e227639aad006ef51e997a1d62187
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Fri Sep 14 02:52:27 2018

fixup! CC: Support the memory pressure handler in GpuImageDecodeCache

The initialization of |memory_pressure_listener_| has been doing in the
destructor of GpuImageDecodeCache. This should be done by the constructor.
This CL fixes it.

Bug:  856527 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0e4d4ace3976285cf236596d9f6eafb8d4a350dd
Reviewed-on: https://chromium-review.googlesource.com/1223552
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#591273}
[modify] https://crrev.com/f05b8f9d363e227639aad006ef51e997a1d62187/cc/tiles/gpu_image_decode_cache.cc

Sign in to add a comment