New issue
Advanced search Search tips

Issue 856516 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task

Blocked on:
issue 882074



Sign in to add a comment

Clean up clang ios upstream builders

Project Member Reported by justincohen@chromium.org, Jun 26 2018

Issue description

1) Add simulator tests to ToTiOS
2) Rename clang_tot_device/ to ToTiOSDevice
3) Move device from 10 to 11, in an attempt to get green
4) Get ToTiOSDevice green
 
thakis@ am I missing anything here?

Comment 2 by thakis@chromium.org, Jun 26 2018

The name of the bot isn't super important I guess, but "get it green" sounds good :-)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/59f7207e9ec5baef81fc8b76e078f0a848d2fe2c

commit 59f7207e9ec5baef81fc8b76e078f0a848d2fe2c
Author: Justin Cohen <justincohen@google.com>
Date: Thu Aug 30 16:23:18 2018

Rename clang_tot_device -> ToTiOSDevice.

Bug:  856516 
Change-Id: I7f05089f8da3d63d59da022bfdaf461d31e8b1eb
Reviewed-on: https://chromium-review.googlesource.com/1197062
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>

[modify] https://crrev.com/59f7207e9ec5baef81fc8b76e078f0a848d2fe2c/masters/master.chromium.clang/builders.pyl

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d28feb9db3cc93a736ec800a75faf55f966f943

commit 7d28feb9db3cc93a736ec800a75faf55f966f943
Author: Justin Cohen <justincohen@google.com>
Date: Thu Aug 30 16:57:50 2018

[ios] Add tests to clang simulator build, and rename device bot.

Bug:  856516 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I793838671588db112b478e9d7e936dea3b430426
Reviewed-on: https://chromium-review.googlesource.com/1197082
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587630}
[modify] https://crrev.com/7d28feb9db3cc93a736ec800a75faf55f966f943/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/7d28feb9db3cc93a736ec800a75faf55f966f943/ios/build/bots/chromium.clang/ToTiOS.json
[rename] https://crrev.com/7d28feb9db3cc93a736ec800a75faf55f966f943/ios/build/bots/chromium.clang/ToTiOSDevice.json

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd97101eba71e390bd9fe8be06da6e08048897ec

commit dd97101eba71e390bd9fe8be06da6e08048897ec
Author: Justin Cohen <justincohen@google.com>
Date: Thu Aug 30 23:52:49 2018

[ios] Update ToTiOSDevice to match device @ iOS 11.4.

Bug:  856516 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I52bee9bcd13d835eab5592bee12c48b95c25c233
Reviewed-on: https://chromium-review.googlesource.com/1197923
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587856}
[modify] https://crrev.com/dd97101eba71e390bd9fe8be06da6e08048897ec/ios/build/bots/chromium.clang/ToTiOSDevice.json

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a2d316d91c607a7d2b3839f427e369d940766f7

commit 5a2d316d91c607a7d2b3839f427e369d940766f7
Author: Justin Cohen <justincohen@google.com>
Date: Wed Sep 05 00:38:20 2018

[ios] Stop building superfat tot clang simulator build.

Also add better targeting for simulator and device tests.

Bug:  856516 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0b3540e1386ef2cf7f3803365add681ff36ee2b1
Reviewed-on: https://chromium-review.googlesource.com/1205535
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588718}
[modify] https://crrev.com/5a2d316d91c607a7d2b3839f427e369d940766f7/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/5a2d316d91c607a7d2b3839f427e369d940766f7/ios/build/bots/chromium.clang/ToTiOS.json
[modify] https://crrev.com/5a2d316d91c607a7d2b3839f427e369d940766f7/ios/build/bots/chromium.clang/ToTiOSDevice.json

Cc: jbudorick@chromium.org
Almost there.
https://ci.chromium.org/buildbot/chromium.clang/ToTiOS/ is green
https://ci.chromium.org/buildbot/chromium.clang/ToTiOSDevice/ is green

However, I think the console https://ci.chromium.org/p/chromium/g/chromium.clang/console is still messed up bewteen pre- and post- LUCI.

thakis@ what console does chromium.clang sheriff look at?

jbudorick@ FYI 
Blockedon: 882074
Console wonkiness appears to be resolved.
Status: Fixed (was: Assigned)
Thanks!  Everything looks green, marking as Fixed!

Sign in to add a comment