New issue
Advanced search Search tips

Issue 856510 link

Starred by 2 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Jun 2018
Cc:
bsep@chromium.org
nyerramilli@chromium.org
kylixrd@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Focus is not seen properly on wrench menu icon.

Reported by shruti.j...@etouch.net, Jun 26 2018 
Chrome Version: 69.0.3473.0 (Official Build)Revision cd23eb9e98a965ea157e23052bb62553e5d520d5-refs/branch-heads/3473@{#1} (32/64-bit)
OS: Windows(7,8,8.1,10)

Pre-condition:Enable 'Force UI Direction'.

Steps to reproduce:
1.Launch chrome and click on wrench menu.
2.Observe focus on wrench menu icon.

Actual:Focus is not seen properly on wrench menu icon.
Expected:Focus should be seen properly on wrench menu icon.

This is regression issue broken in ‘M-69’ and will soon provide per revision-bisect info:
Good Build:69.0.3472.0
Bad Build:69.0.3473.0


Kindly refer the attached video.

Thank You!
Actual_Result.mp4
260 KB View Download
Expected_Result.mp4
249 KB View Download

Comment 1 by shruti.j...@etouch.net, Jun 26 2018

Labels: OS-Linux
Owner: kylixrd@chromium.org
Status: Assigned (was: Unconfirmed)
Unable to provide bisect using per-revision script,Hence providing bisect with old script: 
Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/3c16d9d466102e0839cad4e70cea850107143ca4..64c540a750df6adb453c0f8e6e63800d8948d04c

Suspect:https://chromium.googlesource.com/chromium/src/+/8a4187003e401bcb6a541427fe72fc425c5a9f1b

@Allen Bauer : Could you please help to reassign if your change is not the cause for this change. 

Thank You.

Comment 2 by shruti.j...@etouch.net, Jun 26 2018

Labels: RegressedIn-69 hasbisect

Comment 3 by kylixrd@chromium.org, Jun 26 2018

Cc: bsep@chromium.org kylixrd@chromium.org
Labels: Proj-MdRefresh
Owner: pbos@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/276e131f4b57cc7e89fedf662d9ef09b53a1a898

commit 276e131f4b57cc7e89fedf662d9ef09b53a1a898
Author: Peter Boström <pbos@chromium.org>
Date: Wed Jun 27 00:53:14 2018

Fix ToolbarButton InkDrop inset positioning in RTL

Fixes InkDrop clipping for non-centered (edge) ToolbarButtons when
rendered in RTL (when rendered flipped).

Bug:  chromium:856510 
Change-Id: Ie83bfc3b1fd1e8815dae25beeb83f86d89c375c4
Reviewed-on: https://chromium-review.googlesource.com/1115964
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570595}
[modify] https://crrev.com/276e131f4b57cc7e89fedf662d9ef09b53a1a898/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h

Comment 5 by shruti.j...@etouch.net, Jun 27 2018

Labels: TE-Verified-M69 TE-Verified-69.0.3474.0
Update : 
Retested above issue on OS: Windows(7,8,8.1,10) using latest Canary #69.0.3474.0 and issue is fixed.Focus appears properly on wrench menu.Kindly review the attached screen-cast.

Thank you!
Canary_Behaviour69.0.3474.0.mp4
275 KB View Download

Comment 6 by bsep@chromium.org, Jun 27 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment