New issue
Advanced search Search tips

Issue 856505 link

Starred by 2 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Jun 2018
Cc:
bsep@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Focus does not travel to reload button after pressing tab key

Reported by pranjali...@etouch.net, Jun 26 2018 
Chrome version :  69.0.3473.0 (Official Build) cd23eb9e98a965ea157e23052bb62553e5d520d5-refs/branch-heads/3473@{#1}(32/64-bit) 

OS : Win(7,8,8.1,10)OS

Steps to reproduce:
1. Launch chrome and open NTP.
2. Press F6 to bring focus on omnibox and press tab key until focus reaches to reload button..
3. Observe.

Actual Result: Focus does not travel to reload button after pressing tab key
Expected Result: Focus should travel to reload button after pressing tab key

This is a regression issue broken in ‘M-69’ and will soon update other bisect info.
Good build: 69.0.3472.0
Bad build: 69.0.3473.0
Actual_result.mp4
321 KB View Download
Expected_result.mp4
334 KB View Download

Comment 1 by pranjali...@etouch.net, Jun 26 2018

Labels: hasbisect OS-Linux
Owner: kylixrd@chromium.org
Status: Assigned (was: Unconfirmed)
Unable to provide bisect using per-revision script,Hence providing bisect with old script: 
Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/3c16d9d466102e0839cad4e70cea850107143ca4..64c540a750df6adb453c0f8e6e63800d8948d04c

Suspect: https://chromium.googlesource.com/chromium/src/+/8a4187003e401bcb6a541427fe72fc425c5a9f1b

@Allen Bauer: Could you please help to reassign if your change is not the cause for this change. 

Thank You.

Comment 2 by kylixrd@chromium.org, Jun 26 2018

Cc: bsep@chromium.org pkasting@chromium.org
Labels: Proj-MdRefresh
Owner: pbos@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa6fc088fc7664d44f333a5b5b9d6e92b15e0dd5

commit aa6fc088fc7664d44f333a5b5b9d6e92b15e0dd5
Author: Peter Boström <pbos@chromium.org>
Date: Tue Jun 26 22:36:44 2018

Show InkDrops on toolbar-button focus outside Mac

Highlights the ToolbarButton inkdrop on platforms where focus rings are
not used. Before this change toolbar buttons were not highlighted to
reflect their focused state (outside of Mac where focus rings are used).

Bug:  chromium:856505 
Change-Id: Iab3578ff75a12477afa11ce34a09836acc3514d9
Reviewed-on: https://chromium-review.googlesource.com/1115737
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570561}
[modify] https://crrev.com/aa6fc088fc7664d44f333a5b5b9d6e92b15e0dd5/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h

Comment 4 by pbos@chromium.org, Jun 26 2018

Status: Fixed (was: Assigned)

Comment 5 by pranjali...@etouch.net, Jun 27 2018

Labels: TE-Verified-M69 TE-Verified-69.0.3474.0
Update:

Rechecked the above issue on Win(7,8,8.1,10) and Linux(14.04 LTS)OS using latest canary build #69.0.3474.0 and issue is fixed.Focus is seen on reload button after pressing tab key.

Please refer attached screen cast for reference.

Thank You.
Canary_behaviour.mp4
499 KB View Download
►

Sign in to add a comment