Bump up the contrast for the hover state:  

background color: GG300 
icon color: GG800 

Color palette: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g3232c09376_6_798

Deleted: default.png 9.1 KB

	default.png 9.1 KB View Download

Deleted: hover.png 9.4 KB

	hover.png 9.4 KB View Download

How do the colors adapt to variable backgrounds?  Presumably we just invert* both of these when against a darker background, like normal?

*Not really invert, but blend toward the opposite endpoint

It probably makes sense to track this work also in 838152 (Paint the tab close button circle highlight programmatically.)

I don't think these two should be dupes.

 Issue 860231  has been merged into this issue.

Sending to bettes to answer #2.

Re #2: yes, I think blending to opposite luma is expected here. Assigning back to you. 

I think this is pretty high priority for M69 accessibility and I also don't feel confident of my ability to get to it in time.  ->kylixrd to either take or find another owner, unless I can clear my plate sooner than I think.

This is using a simple BlendTowardOppositeLuma() call. It's probably too stark of a difference for what the designers want...

Deleted: ContrastingHoveredCloseButton.png 4.0 KB

	ContrastingHoveredCloseButton.png 4.0 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52e71c0e747870b84336ee33ba1c27fff5aafbcd

commit 52e71c0e747870b84336ee33ba1c27fff5aafbcd
Author: Allen Bauer <kylixrd@chromium.org>
Date: Wed Aug 08 14:08:01 2018

Paint close(X) icon and generate colors with specific contrast ratios.

TBR=estade@chromium.org

Bug:  838152 
Bug:  856492 
Change-Id: Ie16b4fd47d3e0f614a0f793300539729c905e5a0
Reviewed-on: https://chromium-review.googlesource.com/1162664
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581553}
[modify] https://crrev.com/52e71c0e747870b84336ee33ba1c27fff5aafbcd/chrome/app/vector_icons/BUILD.gn
[delete] https://crrev.com/46b03fcf88a29480afce6f0209cd17d872afa8e1/chrome/app/vector_icons/tab_close_button_touch.icon
[modify] https://crrev.com/52e71c0e747870b84336ee33ba1c27fff5aafbcd/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/52e71c0e747870b84336ee33ba1c27fff5aafbcd/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/52e71c0e747870b84336ee33ba1c27fff5aafbcd/chrome/browser/ui/views/tabs/tab_close_button.cc
[modify] https://crrev.com/52e71c0e747870b84336ee33ba1c27fff5aafbcd/chrome/browser/ui/views/tabs/tab_close_button.h

This should get merged to M69, but we should fix  bug 873063  first.

Leaving open until those are done.

This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Can I wait until  bug 873063  is fixed before approving merge to M69?

Yes, in fact you should wait :)

Thank you, pls update the bug once  bug 873063  is fixed and this is ready to merge. 

We should be good to merge the CL in comment 14 and on  bug 873063  now.

Approving merge to M69 branch 3497 based on comment #21. Pls merge. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d9d76e351a9867e05843c98fdb3ae5307793594

commit 2d9d76e351a9867e05843c98fdb3ae5307793594
Author: Peter Kasting <pkasting@chromium.org>
Date: Wed Aug 15 15:51:47 2018

Paint close(X) icon and generate colors with specific contrast ratios.

TBR=estade@chromium.org, kylixrd@chromium.org

Bug:  838152 
Bug:  856492 
Change-Id: Ie16b4fd47d3e0f614a0f793300539729c905e5a0
Reviewed-on: https://chromium-review.googlesource.com/1162664
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581553}(cherry picked from commit 52e71c0e747870b84336ee33ba1c27fff5aafbcd)
Reviewed-on: https://chromium-review.googlesource.com/1175856
Cr-Commit-Position: refs/branch-heads/3497@{#640}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2d9d76e351a9867e05843c98fdb3ae5307793594/chrome/app/vector_icons/BUILD.gn
[delete] https://crrev.com/f3a18f9491330d76058b2de0981cf97896286c30/chrome/app/vector_icons/tab_close_button_touch.icon
[modify] https://crrev.com/2d9d76e351a9867e05843c98fdb3ae5307793594/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/2d9d76e351a9867e05843c98fdb3ae5307793594/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/2d9d76e351a9867e05843c98fdb3ae5307793594/chrome/browser/ui/views/tabs/tab_close_button.cc
[modify] https://crrev.com/2d9d76e351a9867e05843c98fdb3ae5307793594/chrome/browser/ui/views/tabs/tab_close_button.h

Tried verifying the fix on chrome version# 69.0.3497.42 using Mac 10.12.6, Ubuntu 14.04 and Windows-10 with steps mentioned below:
1) Launched chrome reported version and compared the behaviour of background tab close button with previous beta and didn't find the difference in close tab button

@Peter Kasting: Please find the attached screenshots of Linux, Win and Mac and help us in verifying the fix.

Thanks!

Deleted: 856492 - Linux.png 189 KB

	856492 - Linux.png 189 KB View Download

Deleted: 856492 - Mac.png 144 KB

	856492 - Mac.png 144 KB View Download

Deleted: 856492 - Windows.PNG 139 KB

	856492 - Windows.PNG 139 KB View Download

Try using Windows and setting your title bars to colored, with some darker accent color.  Then hover a background tab's close button and verify that the close X is still visible in the highlight circle.

I can get some screenshots of good and bad state late this afternoon if you need those as a comparison point.

A sample bad state looks like the image on comment 0.  A good state would look more like the attached.  Ignore the color of the hover effect on the tab; this bug is just about the "X" in the close button and whether it contrasts with the circle around it.

Deleted: Untitled.png 1.3 KB

	Untitled.png 1.3 KB View Download

Able to reproduce the issue on chrome reported version 69.0.3472.0(Build without fix)
Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #69.0.3497.42 as per the comment#0 & 29
Attaching screenshot for reference.
Observed "Able to see 'X' in dark colour in close tab button"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!

Deleted: 856492.png 32.0 KB

	856492.png 32.0 KB View Download