update of upload_goma_logs.py.vpython seems to be ignored. |
||||||
Issue descriptionWhen I try to check the behavior of following cl with led, it seems to ignore upload_goma_logs.py.vpython even if I add upload_goma_logs.py.vpython in .gitattributes. https://chromium-review.googlesource.com/c/chromium/tools/build/+/1086431
,
Jun 27 2018
,
Jun 27 2018
Link to led triggered swarming task?
,
Jun 27 2018
Can you confirm that the contents in the isolated file (https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=6b6f09d3417effcc07d29b40b9c1379eda8d43c6&as=upload_goma_logs.py.vpython) do not match what you expect?
,
Jun 27 2018
(specifically, I see that it includes the 1.4.0 change)
,
Jun 27 2018
Re: #5 Hmm, this seems to match what I want. However, as far as I checked what is in infra_libs 1.4.0, it seems to have https://chromium-review.googlesource.com/c/infra/infra/+/1070908. Then, we won't see "infra_libs.ts_mon.common.errors.MonitoringTooManyFieldsError: Metric "goma/failure_reason" was given too many (9 > 7) fields:" Why infra_libs used for vpython seems not have what should be contained in 1.4.0?
,
Jun 27 2018
I'm not sure; I don't know how 1.4.0 was packaged. Can you inspect the cipd package for 1.4.0 to see if it has what you expect? $ cipd pkg-fetch infra/python/wheels/infra_libs-py2 -version version:1.4.0 -out pkg.zip $ mkdir tmp $ cd tmp $ unzip ../pkg.zip $ unzip infra_libs-1.4.0-py2.py3-none-any.whl
,
Jun 27 2018
Actually, it does seem to have this:
if len(field_spec) > 12:
# Monarch imposes a limit of a cardinality of 5000 for a single metric
# (see http://shortn/_WBupjZf2of).
# If a user set 12 fields, and each of those is just a boolean field
# with two possible values, the _lower limit_ on the cardinality of
# that metric is 2^12, or 4096.
# Note that since a combination of 5 built-in fields is fixed, we do
# not need to count them.
raise errors.MonitoringTooManyFieldsError(self._name, field_spec)
,
Jun 29 2018
I started to think this is not led issue but vpython issue. I have rolled https://chromium-review.googlesource.com/c/chromium/tools/build/+/1086431, which set the metrics > 7. Then, we started to see python execution failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/83219 https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942463272907379472%2F%2B%2Fsteps%2Fpostprocess_for_goma%2F0%2Fsteps%2Fupload_log%2F0%2Fstdout Since infra_lib 1.4.0 should not rise such an exception, I am quite sure that infra_lib 1.4.0 was not used for execution ts_mon.
,
Jul 10
,
Oct 18
,
Oct 18
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by qyears...@chromium.org
, Jun 26 2018