New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856486 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Build-Toolchain



Sign in to add a comment

toolchain-utils: stop using toolchain_utils.sh

Project Member Reported by vapier@chromium.org, Jun 26 2018

Issue description

we're trying to kill this file off, but toolchain-utils has a few references to it still.  can we clean these up ?

specifically:
- cros_utils/misc.py: stop using get_ctarget_from_board
- cros_utils/misc.py: stop using get_board_arch

before trying to inline the code, might be useful to see if you can just delete the python consumers altogether ...
 
Owner: laszio@chromium.org
Status: Assigned (was: Untriaged)
i just moved the file into the toolchain-utils repo:
  https://chromium-review.googlesource.com/1163163

i'll leave it to you guys how much more cleanup you want to do here, but the rest of the tree is unblocked.
Mike, I see a bunch of these errors in Setup Board stage:

/usr/bin/cros_choose_profile: line 27: /mnt/host/source/src/platform/dev/toolchain_utils.sh: No such file or directory 

e.g. https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Freef-paladin%2F6544%2F%2B%2Frecipes%2Fsteps%2FSetupBoard%2F0%2Fstdout

https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Fkevin-paladin%2F5315%2F%2B%2Frecipes%2Fsteps%2FSetupBoard%2F0%2Fstdout

Sign in to add a comment