New issue
Advanced search Search tips

Issue 856465 link

Starred by 1 user
Status: Verified
Owner:
chengong@chromium.org
Closed: Jul 19
Cc:
shuchen@chromium.org
wuyingbing@chromium.org
zhan...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Unchecking "Enable gesture typing" make no sense.

Project Member Reported by xiulingw@chromium.org, Jun 26 2018 
Version 69.0.3464.0(Official build) canary (32-bit)
Platform 10184.0.0（official build) canary-channel kevin
Firmware Google_Kevin.8785.264.0


REPRO STEPS:
1.Switch to US keyboard.
2.Uncheck "Enable gesture typing" for US keyboard.
3.Slide on the keyboard.


Actual result: 
Gesture typing still work.
May 7 2018 3_51 PM.webm
1.3 MB View Download

Comment 1 by wuyingbing@chromium.org, Jul 11

Owner: chengong@chromium.org
Currently, preference haven't passed to touch handler manager.
However, please make sure touch handler manager support the preference changed.
I will implement pass preference tomorrow.

Comment 2 by chengong@chromium.org, Jul 18

Status: Started (was: Assigned)

Comment 3 by wuyingbing@chromium.org, Jul 19

Status: Fixed (was: Started)
please verify in next version
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/9a498c1e6d61ba83e6d75b13a1a51c5936be14ec

commit 9a498c1e6d61ba83e6d75b13a1a51c5936be14ec
Author: Chen Gong <chengong@google.com>
Date: Fri Jul 20 12:31:33 2018

Comment 5 by wuyingbing@chromium.org, Jul 25

Labels: Merge-Approved-69

Comment 6 by wuyingbing@chromium.org, Jul 27

Labels: -Merge-Approved-69 Merge-Request-69
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 28

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 31

Cc: wuyingbing@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 6 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by xiulingw@chromium.org, Sep 13

Status: Verified (was: Fixed)
Verified fixed on the latest version: 71.0.3544.0, 11059.0.0 canary-channel kevin.
►

Sign in to add a comment