New issue
Advanced search Search tips

Issue 856416 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug

Blocked on:
issue 822474



Sign in to add a comment

Implement WebRunner sys::Runner service for Fuchsia

Project Member Reported by kmarshall@chromium.org, Jun 26 2018

Issue description

Implement a Runner FIDL service executable so that Fuchsia executables can embed Chrome views as mods.
 
Owner: kmarshall@chromium.org
Status: Assigned (was: Untriaged)
Blockedon: 822474
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d2d4522f623bc3eca4a57fff8161820da12209e

commit 4d2d4522f623bc3eca4a57fff8161820da12209e
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Jul 11 00:41:03 2018

[Fuchsia] Implement WebRunner as a sys::Runner service.

* Add RunnerImpl for servicing Runner FIDL requests.
* Add ComponentController class for managing the lifetime of connected
  Runner clients, and servicing ViewProvider::CreateView() calls.
* Add "runner" package, deployment scripts, etc.
* Modify ScopedServiceBinding to support multiple clients.

Bug: 856416
Change-Id: I1b3fd00e868f5eed6842f711986a13c0296a4c07
Reviewed-on: https://chromium-review.googlesource.com/1114377
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573996}
[modify] https://crrev.com/4d2d4522f623bc3eca4a57fff8161820da12209e/webrunner/BUILD.gn
[add] https://crrev.com/4d2d4522f623bc3eca4a57fff8161820da12209e/webrunner/app/component_controller_impl.cc
[add] https://crrev.com/4d2d4522f623bc3eca4a57fff8161820da12209e/webrunner/app/component_controller_impl.h
[add] https://crrev.com/4d2d4522f623bc3eca4a57fff8161820da12209e/webrunner/app/main.cc
[add] https://crrev.com/4d2d4522f623bc3eca4a57fff8161820da12209e/webrunner/app/web_content_runner.cc
[add] https://crrev.com/4d2d4522f623bc3eca4a57fff8161820da12209e/webrunner/app/web_content_runner.h
[rename] https://crrev.com/4d2d4522f623bc3eca4a57fff8161820da12209e/webrunner/service/web_content_service_main.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7c234b0272dff6ce746e9eaac813497986913c3

commit f7c234b0272dff6ce746e9eaac813497986913c3
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Jul 12 16:39:02 2018

[Fuchsia] Address CR comments in sys::Runner implementation

When addressing comments on https://crrev.com//c//1114377 I hit CQ+1
prematurely and landed the change without my changes that addresed
review comments. Landing them separately.

Bug: 856416
Change-Id: I1b691d824f381e9ec0a75ff7ce90b2f45171c13a
Reviewed-on: https://chromium-review.googlesource.com/1133968
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574598}
[modify] https://crrev.com/f7c234b0272dff6ce746e9eaac813497986913c3/webrunner/BUILD.gn
[modify] https://crrev.com/f7c234b0272dff6ce746e9eaac813497986913c3/webrunner/app/component_controller_impl.cc
[modify] https://crrev.com/f7c234b0272dff6ce746e9eaac813497986913c3/webrunner/app/component_controller_impl.h
[modify] https://crrev.com/f7c234b0272dff6ce746e9eaac813497986913c3/webrunner/app/main.cc
[modify] https://crrev.com/f7c234b0272dff6ce746e9eaac813497986913c3/webrunner/app/web_content_runner.cc
[modify] https://crrev.com/f7c234b0272dff6ce746e9eaac813497986913c3/webrunner/app/web_content_runner.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c40e749cd5d48a9ee9fd02f822c18857d52b813b

commit c40e749cd5d48a9ee9fd02f822c18857d52b813b
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Jul 12 18:33:44 2018

[Fuchsia] Update webrunner to quit when sys::Runner is closed.

appmgr process normally creates a single sys::Runner connection for
each runner process and then closes it when it no longer needs the
runner. Updagted webrunner implementation to quit after sys::Runned
is destroyed.

Bug: 856416
Change-Id: I071b37093917a932a837eebfdf1f1a6e23e837de
Reviewed-on: https://chromium-review.googlesource.com/1134415
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574644}
[modify] https://crrev.com/c40e749cd5d48a9ee9fd02f822c18857d52b813b/base/fuchsia/scoped_service_binding.h
[modify] https://crrev.com/c40e749cd5d48a9ee9fd02f822c18857d52b813b/base/fuchsia/service_directory_unittest.cc
[modify] https://crrev.com/c40e749cd5d48a9ee9fd02f822c18857d52b813b/webrunner/app/main.cc

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f64b82677f39d0b8feb880e781fd0d5c7efa75d

commit 4f64b82677f39d0b8feb880e781fd0d5c7efa75d
Author: Wez <wez@chromium.org>
Date: Tue Oct 30 20:46:08 2018

Move web Runner implementation to //webrunner/app/{web,common}.

- Expose WebContentRunner's constructor to derived classes.
- Move the common Runner and Component implementations under "common".
- Move the scoped service publishing binding into WebContentRunner.
- Move the default web.Context creation helper to the WebContentRunner.
- Rename the ComponentControllerImpl to WebComponent.
- Rename WebComponent::RequestTermination to ...::DestroyComponent.

Bug: 893229, 856416
Change-Id: Ia4b8036d5f1b6f00472d201b7cb9dcf063377122
Reviewed-on: https://chromium-review.googlesource.com/c/1301114
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604002}
[modify] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/webrunner/BUILD.gn
[add] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/webrunner/app/common/web_component.cc
[add] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/webrunner/app/common/web_component.h
[add] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/webrunner/app/common/web_content_runner.cc
[add] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/webrunner/app/common/web_content_runner.h
[delete] https://crrev.com/f5ee8af906c44c35d85b2294ffd05cb26218b111/webrunner/app/component_controller_impl.cc
[delete] https://crrev.com/f5ee8af906c44c35d85b2294ffd05cb26218b111/webrunner/app/component_controller_impl.h
[delete] https://crrev.com/f5ee8af906c44c35d85b2294ffd05cb26218b111/webrunner/app/main.cc
[add] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/webrunner/app/web/main.cc
[rename] https://crrev.com/4f64b82677f39d0b8feb880e781fd0d5c7efa75d/webrunner/app/web/sandbox_policy
[delete] https://crrev.com/f5ee8af906c44c35d85b2294ffd05cb26218b111/webrunner/app/web_content_runner.cc
[delete] https://crrev.com/f5ee8af906c44c35d85b2294ffd05cb26218b111/webrunner/app/web_content_runner.h

Sign in to add a comment