New issue
Advanced search Search tips

Issue 856405 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Rename kLanguageEnabledExtensionImes pref to kLanguageEnabledImes

Project Member Reported by yhanada@chromium.org, Jun 26 2018

Issue description

Spun off from crrev.com/c/1109441 .

Now the pref contains ARC++ IMEs which is not extensions. Let's rename it.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dcf2e8570a6e96d03e96970436fcd769c3f1322

commit 1dcf2e8570a6e96d03e96970436fcd769c3f1322
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Mon Jul 02 22:38:38 2018

Rename prefs::kLanguageEnabledExtensionImes{,Syncable}.

to kLanguageEnabledImes{,Syncable}.
Now these prefs can contain ARC IMEs that are not extension-based.

Bug:  856405 
Change-Id: I84c1f7fc963fac51099c48a2a2265ba9fdc89626
Reviewed-on: https://chromium-review.googlesource.com/1122021
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572027}
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/browser/chromeos/input_method/input_method_syncer.cc
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/browser/chromeos/input_method/input_method_syncer.h
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/browser/chromeos/preferences.h
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/browser/chromeos/preferences_unittest.cc
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/browser/extensions/api/language_settings_private/language_settings_private_api_unittest.cc
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/common/pref_names.cc
[modify] https://crrev.com/1dcf2e8570a6e96d03e96970436fcd769c3f1322/chrome/common/pref_names.h

Status: Fixed (was: Started)

Sign in to add a comment