Issue metadata
Sign in to add a comment
|
CCPR breaks VR pixeltests |
||||||||||||||||||||||||||
Issue descriptionWhile running the modified versions of the VR pixeltests from https://chromium-review.googlesource.com/c/chromium/src/+/748267 on the bots, I found that they are currently broken, rendering nothing but the pointer and floor grid (see https://chrome-vr-gold.skia.org/img/images/69fe6dacb26833a027ce52b3a7687ca3.png). A bisect points to https://skia.googlesource.com/skia.git/+/a2b5b6467f347962e0d6942da0dff9148fbb3375 as the culprit CL. However, the browser seems to be functioning fine on Android, so it's possible it's just the test doing something weird. The issue with not rendering most things seems to only be on the bots. When run locally, I get a mostly correct scene, although half the URL bar is missing and the sides aren't rounded. See the attached screenshot.
,
Jun 26 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34c02d5dab3871123295311575013dc22e6af1c3 commit 34c02d5dab3871123295311575013dc22e6af1c3 Author: bsheedy <bsheedy@chromium.org> Date: Wed Jun 27 15:11:21 2018 Disable CCPR for VR Disables Skia's CCPR support for the VR browser since it somehow causes serious rendering issues. This workaround can be removed once the root cause is found and fixed. Requires that https://skia-review.googlesource.com/c/skia/+/137763 be landed and rolled first. Bug: 856404 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4121319cae3a465798077cfeac058d84e9e9dd93 Reviewed-on: https://chromium-review.googlesource.com/1116066 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#570775} [modify] https://crrev.com/34c02d5dab3871123295311575013dc22e6af1c3/chrome/browser/vr/ganesh_surface_provider.cc
,
Jun 27 2018
With csmartdalton@ help, we figured the culprit GL call. I'm now taking the ownership in chromium side.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/909ffffa9d7a883290b314f5075daf35e6f2942e commit 909ffffa9d7a883290b314f5075daf35e6f2942e Author: Aldo Culquicondor <acondor@chromium.org> Date: Fri Jun 29 15:16:06 2018 VR: Add separate GL context for skia This avoids any corruption of the state between chromium and Skia. Bug: 856404 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib77c4d23d0aa2ba8704499f2f2e12a93c5ec9609 Reviewed-on: https://chromium-review.googlesource.com/1117741 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#571481} [modify] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/android/vr/vr_shell_gl.cc [modify] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/android/vr/vr_shell_gl.h [modify] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/vr/ganesh_surface_provider.cc [add] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/vr/graphics_delegate.cc [add] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/vr/graphics_delegate.h [modify] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/vr/test/gl_test_environment.cc [modify] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/vr/test/gl_test_environment.h [modify] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/vr/testapp/gl_renderer.cc [modify] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/vr/testapp/gl_renderer.h [modify] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/909ffffa9d7a883290b314f5075daf35e6f2942e/chrome/browser/vr/testapp/vr_test_context.h
,
Jun 29 2018
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by bsheedy@chromium.org
, Jun 26 2018