New issue
Advanced search Search tips

Issue 856393 link

Starred by 1 user
Status: Assigned
Owner:
xiy...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

"KioskTest.ZoomSupport" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 26 2018 
"KioskTest.ZoomSupport" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyIAsSBUZsYWtlIhVLaW9za1Rlc3QuWm9vbVN1cHBvcnQM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Jun 27 2018 

Detected 25 new flakes for test/step "KioskTest.ZoomSupport". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyIAsSBUZsYWtlIhVLaW9za1Rlc3QuWm9vbVN1cHBvcnQM. This message was posted automatically by the chromium-try-flakes app.

Comment 2 by grt@chromium.org, Jun 27 2018

Labels: OS-Chrome
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)
Why is this test using DCHECK for test expectations?

  DCHECK_LT(width_zoomed_in, original_width);

[8019:8019:0626/123446.506853:FATAL:kiosk_browsertest.cc(871)] Check failed: width_zoomed_in < original_width (1280 vs. 1280)

Please change it to use EXPECT_LT or ASSERT_LT as appropriate. Tests shouldn't crash when an expectation isn't met.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b27bf98d43165069537f11b89985de130742f6d0

commit b27bf98d43165069537f11b89985de130742f6d0
Author: Greg Thompson <grt@chromium.org>
Date: Wed Jun 27 10:20:50 2018

Disable flaky KioskTest.ZoomSupport.

BUG=856393
TBR=xiyuan@chromium.org
NOTRY=true

Change-Id: Icd9e1d02102ea6abab544141eb307f1e39342802
Reviewed-on: https://chromium-review.googlesource.com/1116707
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570722}
[modify] https://crrev.com/b27bf98d43165069537f11b89985de130742f6d0/chrome/browser/chromeos/login/kiosk_browsertest.cc

Comment 4 by grt@chromium.org, Jun 27 2018

Labels: -Sheriff-Chromium
►

Sign in to add a comment