Make example.DBus Tast test not fail on devices that don't have backlights |
||
Issue descriptionI noticed that the example.DBus Tast test is failing on devices that don't have internal backlights with "Failed to get screen brightness: Couldn't fetch brightness". This is expected behavior from powerd; I should change the example test to call some other method.
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/c5ec15b6a717be329b085438feb47cf89f7d3515 commit c5ec15b6a717be329b085438feb47cf89f7d3515 Author: Daniel Erat <derat@chromium.org> Date: Wed Jun 27 17:31:40 2018 tast-tests: Make example.DBus call session_manager. Make the example.DBus test call session_manager's RetrieveSessionState method rather than powerd's GetScreenBrightnessPercent method. GetScreenBrightnessPercent intentionally fails on devices that don't have internal backlights (e.g. Chromeboxes, Chromebases, etc.), so it isn't the best choice for example code. BUG= chromium:856390 TEST=ran "tast run <dut> example.DBus" and saw it pass Change-Id: I75e5956dddea0122d56e8407c766d34db17c64fa Reviewed-on: https://chromium-review.googlesource.com/1115213 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> [modify] https://crrev.com/c5ec15b6a717be329b085438feb47cf89f7d3515/src/chromiumos/tast/local/bundles/cros/example/dbus.go
,
Jun 27 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by derat@chromium.org
, Jun 26 2018