https://chromium-review.googlesource.com/c/chromium/src/+/1114329

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feee33d799c4c3750510830f7b620bd35022fba8

commit feee33d799c4c3750510830f7b620bd35022fba8
Author: Thomas Guilbert <tguilbert@chromium.org>
Date: Tue Jun 26 02:38:39 2018

Initialize |incremental_apk_exists|

Fixes a script crash from |incremental_apk_exists| being used without
being initialized.

NOTRY=true # bot failures unrelated

Bug:  856384 
Change-Id: Iea429a58610bc9d409f35ee6b5cf3314bb12eab7
Reviewed-on: https://chromium-review.googlesource.com/1114329
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570306}
[modify] https://crrev.com/feee33d799c4c3750510830f7b620bd35022fba8/build/android/apk_operations.py

I'm still running into this. Repro steps:

> ninja -C out/Default/ -j2000 chrome_public_apk && out/Default/bin/chrome_public_apk run --non-incremental

> out/Default/bin/chrome_public_apk uninstall
Traceback (most recent call last):
  File "out/x86Release/bin/chrome_public_apk", line 32, in <module>
    sys.exit(main())
  File "out/x86Release/bin/chrome_public_apk", line 22, in main
    resolve('../apks/ChromePublic.apk.mapping'))
  File "/usr/local/google/home/skym/chromium/clankium/src/build/android/apk_operations.py", line 1276, in Run
    _RunInternal(parser, output_directory=output_directory)
  File "/usr/local/google/home/skym/chromium/clankium/src/build/android/apk_operations.py", line 1254, in _RunInternal
    args.command.ProcessArgs(args)
  File "/usr/local/google/home/skym/chromium/clankium/src/build/android/apk_operations.py", line 875, in ProcessArgs
    if incremental_apk_exists:
UnboundLocalError: local variable 'incremental_apk_exists' referenced before assignment

It seems like for some reason self.supports_incremental is false for me, but was true for others. Posted CL to fix https://chromium-review.googlesource.com/c/chromium/src/+/1118911

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c7f0045e17c4d78f35e8334c153691e176b2471

commit 5c7f0045e17c4d78f35e8334c153691e176b2471
Author: Sky Malice <skym@google.com>
Date: Fri Jun 29 17:42:35 2018

Move initialization of |incremental_apk_exists|

Initialize it regardless of state so that either of the if blocks below
can access it and be safe in doing so.

Bug:  856384 
Change-Id: I2205a3351e0ff0603ccaafd0594aaaf9ca8e29ec
Reviewed-on: https://chromium-review.googlesource.com/1118911
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571522}
[modify] https://crrev.com/5c7f0045e17c4d78f35e8334c153691e176b2471/build/android/apk_operations.py