New issue
Advanced search Search tips

Issue 856364 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 729800



Sign in to add a comment

Add SameSite attribute to Cookie Store API

Project Member Reported by pwnall@chromium.org, Jun 25 2018

Issue description

We should implement SameSite as described in https://github.com/WICG/cookie-store/issues/36#issuecomment-399541553
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c52b093d53d6220e63f157d82fb61d09a1872a7b

commit c52b093d53d6220e63f157d82fb61d09a1872a7b
Author: Victor Costan <pwnall@chromium.org>
Date: Thu Jun 28 00:27:28 2018

Async Cookies: Implement sameSite attribute.

This CL modifies RestrictedCookieManager to allow renderers to set the
SameSite and Priority CanonicalCookie attributes. Renderers must be
allowed to set the SameSite and Priority attributes so that
RestrictedCookieManager can be used to implement the document.cookie
setter.

Bug:  856364 , 729800
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic0a520bc6c02c259ef22175c9eb161086fa18782
Reviewed-on: https://chromium-review.googlesource.com/1115586
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570976}
[modify] https://crrev.com/c52b093d53d6220e63f157d82fb61d09a1872a7b/services/network/restricted_cookie_manager.cc
[modify] https://crrev.com/c52b093d53d6220e63f157d82fb61d09a1872a7b/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieListItem_attributes.tentative.https.window.js
[modify] https://crrev.com/c52b093d53d6220e63f157d82fb61d09a1872a7b/third_party/WebKit/LayoutTests/external/wpt/interfaces/cookie-store.idl
[modify] https://crrev.com/c52b093d53d6220e63f157d82fb61d09a1872a7b/third_party/blink/renderer/modules/cookie_store/cookie_change_event.cc
[modify] https://crrev.com/c52b093d53d6220e63f157d82fb61d09a1872a7b/third_party/blink/renderer/modules/cookie_store/cookie_list_item.idl
[modify] https://crrev.com/c52b093d53d6220e63f157d82fb61d09a1872a7b/third_party/blink/renderer/modules/cookie_store/cookie_store.cc
[modify] https://crrev.com/c52b093d53d6220e63f157d82fb61d09a1872a7b/third_party/blink/renderer/modules/cookie_store/cookie_store_set_options.idl

Comment 2 by pwnall@chromium.org, Jun 28 2018

Status: Fixed (was: Assigned)
Cc: jsb...@chromium.org pwnall@chromium.org
 Issue 848062  has been merged into this issue.
Blockedon: -729800
Blocking: 729800

Sign in to add a comment