New issue
Advanced search Search tips

Issue 856362 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 729800



Sign in to add a comment

Cookie Store API should only be exposed to secure origins

Project Member Reported by pwnall@chromium.org, Jun 25 2018

Issue description

Per the discussion at https://github.com/WICG/cookie-store/issues/21 the Cookie Store API should only be exposed to secure origins. This isn't blocking Origin Trials, as they're already restricted to secure origins.
 

Comment 1 by pwnall@chromium.org, Jun 25 2018

Components: Blink>Storage>CookiesAPI
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a918047d9d517300e8834ead912010cea0cfa0a0

commit a918047d9d517300e8834ead912010cea0cfa0a0
Author: Victor Costan <pwnall@chromium.org>
Date: Wed Jun 27 01:58:12 2018

Async Cookies: The API is only available on secure origins.

Bug:  856362 
Change-Id: Icaddfb82b2c41924cca7f058dea2e8da03183ae9
Reviewed-on: https://chromium-review.googlesource.com/1114379
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570628}
[add] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieListItem_attributes.tentative.https.window.js
[delete] https://crrev.com/ab6b151118fe9b9eea59f14debf215e1390f9963/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieListItem_attributes.tentative.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_delete_arguments.tentative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_delete_basic.tentative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_event_arguments.tenative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_event_basic.tentative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_event_delete.tenative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_event_overwrite.tentative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_getAll_arguments.tentative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_getAll_multiple.tentative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_getAll_set_basic.tentative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_get_arguments.tentative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_get_delete_basic.tentative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_get_set_basic.tentative.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_in_detached_frame.tentative.https.html
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_set_arguments.tentative.https.window.js
[delete] https://crrev.com/ab6b151118fe9b9eea59f14debf215e1390f9963/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_set_expires_option.tentative.window-expected.txt
[delete] https://crrev.com/ab6b151118fe9b9eea59f14debf215e1390f9963/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_set_expires_option.tentative.window.js
[delete] https://crrev.com/ab6b151118fe9b9eea59f14debf215e1390f9963/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_special_names.tentative.html
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_special_names.tentative.https.window.js
[delete] https://crrev.com/ab6b151118fe9b9eea59f14debf215e1390f9963/third_party/WebKit/LayoutTests/external/wpt/cookie-store/document_cookie.tentative.html
[delete] https://crrev.com/ab6b151118fe9b9eea59f14debf215e1390f9963/third_party/WebKit/LayoutTests/external/wpt/cookie-store/http_cookie_and_set_cookie_headers.tentative.html
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/httponly_cookies.https.window.js
[rename] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/idlharness.tentative.https.html
[delete] https://crrev.com/ab6b151118fe9b9eea59f14debf215e1390f9963/third_party/WebKit/LayoutTests/external/wpt/cookie-store/no_name_and_no_value.tentative.html
[delete] https://crrev.com/ab6b151118fe9b9eea59f14debf215e1390f9963/third_party/WebKit/LayoutTests/external/wpt/cookie-store/no_name_equals_in_value.tentative.html
[delete] https://crrev.com/ab6b151118fe9b9eea59f14debf215e1390f9963/third_party/WebKit/LayoutTests/external/wpt/cookie-store/no_name_multiple_values.tentative.html
[modify] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/serviceworker_cookieStore_arguments.js
[modify] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/cookie-store/serviceworker_cookieStore_basic.js
[modify] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/WebKit/LayoutTests/external/wpt/interfaces/cookie-store.idl
[modify] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/blink/renderer/modules/cookie_store/cookie_change_event.idl
[modify] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/blink/renderer/modules/cookie_store/cookie_store.cc
[modify] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/blink/renderer/modules/cookie_store/cookie_store.idl
[modify] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/blink/renderer/modules/cookie_store/cookie_store_set_options.idl
[modify] https://crrev.com/a918047d9d517300e8834ead912010cea0cfa0a0/third_party/blink/renderer/modules/cookie_store/window_cookie_store.idl

Comment 3 by pwnall@chromium.org, Jun 27 2018

Status: Fixed (was: Assigned)

Sign in to add a comment