As we update Vulkan code, any shortcuts taken need to be cleaned up.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/536e75e977985793f8154e13caa788d0f2c535fe commit 536e75e977985793f8154e13caa788d0f2c535fe Author: Chris Blume <cblume@chromium.org> Date: Mon Jun 25 23:08:52 2018 Add header comment for Vulkan swapchain block The swapchain function pointer block is currently missing a header comment. This CL adds it. BUG= 856360 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iade801831fef5a4502f2c66852182f22ef4619aa Reviewed-on: https://chromium-review.googlesource.com/1114220 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#570221} [modify] https://crrev.com/536e75e977985793f8154e13caa788d0f2c535fe/gpu/vulkan/generate_bindings.py [modify] https://crrev.com/536e75e977985793f8154e13caa788d0f2c535fe/gpu/vulkan/vulkan_function_pointers.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1b01bf0f0f01e20924f30a52b8376ac88a1061c commit e1b01bf0f0f01e20924f30a52b8376ac88a1061c Author: Chris Blume <cblume@chromium.org> Date: Wed Jun 27 02:32:38 2018 Move more Vulkan functions into generate_bindings Several Vulkan functions were handled specially because they were near other bindings that need special handling. This CL will move those functions into generate_bindings.py and document the functions which are handled specially. BUG= 856360 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie9ce4f83a27b3b95589ad759cbb1d36c463126a9 Reviewed-on: https://chromium-review.googlesource.com/1115811 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570637} [modify] https://crrev.com/e1b01bf0f0f01e20924f30a52b8376ac88a1061c/gpu/vulkan/generate_bindings.py [modify] https://crrev.com/e1b01bf0f0f01e20924f30a52b8376ac88a1061c/gpu/vulkan/vulkan_function_pointers.cc [modify] https://crrev.com/e1b01bf0f0f01e20924f30a52b8376ac88a1061c/gpu/vulkan/vulkan_function_pointers.h [modify] https://crrev.com/e1b01bf0f0f01e20924f30a52b8376ac88a1061c/gpu/vulkan/vulkan_instance.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65d4258f34de5bdec168410bae0b76171998a35a commit 65d4258f34de5bdec168410bae0b76171998a35a Author: Chris Blume <cblume@chromium.org> Date: Wed Jun 27 23:56:48 2018 Refactor Vulkan's generate_bindings.py The existing generate_bindings.py has some duplicate code. This patch will refactor it to reduce duplication. BUG= 856360 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9776b291f9d984f252c3223d15e755a41156827a Reviewed-on: https://chromium-review.googlesource.com/1116184 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570948} [modify] https://crrev.com/65d4258f34de5bdec168410bae0b76171998a35a/gpu/vulkan/generate_bindings.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3 commit f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3 Author: Chris Blume <cblume@chromium.org> Date: Thu Jun 28 19:35:25 2018 Use macros for Vulkan functions Currently, users of Vulkan need to get the global function pointer class. And calls into those functions look like: vulkan_function_pointers->vkCreateDevice(); Our OpenGL code hides that behind macros. This patch adds macros to mimic the OpenGL code in Chrome. Now that looks like: vkCreateDevice(); BUG= 856360 , 848101 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If3aff1719b366748b9236a9e4c9e7ec69260be18 Reviewed-on: https://chromium-review.googlesource.com/1116195 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571226} [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/components/viz/common/gpu/vulkan_in_process_context_provider.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/generate_bindings.py [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_command_buffer.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_command_pool.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_descriptor_layout.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_descriptor_pool.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_descriptor_set.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_device_queue.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_function_pointers.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_function_pointers.h [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_image_view.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_implementation_android.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_instance.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_render_pass.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_sampler.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_shader_module.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_surface.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/vulkan_swap_chain.cc [modify] https://crrev.com/f0fb42f5e7b27176bd1df7d1024a70cf54ab76f3/gpu/vulkan/x/vulkan_implementation_x11.cc
Comment 1 by bugdroid1@chromium.org
, Jun 25 2018