New issue
Advanced search Search tips

Issue 856352 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

git clang-format may not handle JS conditional (ternary) operator in the correct way

Project Member Reported by wzang@chromium.org, Jun 25 2018

Issue description

git clang-format suggests making the following changes, which looks a little strange:

-    var options =
-        useNewWallpaperPicker ?
-        {
-          frame: 'none',
-          innerBounds: {width: 768, height: 512, minWidth: 768, minHeight: 512},
-          resizable: true,
-          alphaEnabled: true
-        } :
-        {
-          frame: 'none',
-          width: 574,
-          height: 420,
-          resizable: false,
-          alphaEnabled: true
-        };
+    var options = useNewWallpaperPicker ? {
+      frame: 'none',
+      innerBounds: {width: 768, height: 512, minWidth: 768, minHeight: 512},
+      resizable: true,
+      alphaEnabled: true
+    } :
+                                          {
+                                            frame: 'none',
+                                            width: 574,
+                                            height: 420,
+                                            resizable: false,
+                                            alphaEnabled: true
+                                          };



Is this intended?

 

Comment 1 by wzang@chromium.org, Jun 25 2018

Labels: Build-Tools
Yes but I have trying first 
Labels: clang-format

Sign in to add a comment