Issue metadata
Sign in to add a comment
|
[User Feedback - Canary] Google Flights - Unable to search by City / State in the search box, only airport codes accepted |
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3472.0 OS: Windows 10 What steps will reproduce the problem? (1) Go to http://flights.google.com (2) Type in a city or state name (like "Chicago" or "Hawaii") (3) There's no results found, it suggests you to use the 3 letter airport code. What is the expected result? You can type in a city or state name into the search box. What happens instead? It says "Error loading places. Please enter a 3-letter code." I'm not sure if this is a Chrome bug or a Flights bug, although the search box works just fine on Chrome stable 67 & on Firefox, so this may be a Chrome Canary issue. I filed b/110795934 as well.
,
Jun 26 2018
Able to reproduce this issue on Windows 10, Mac OS 10.13.5 and Ubuntu 14.04 on the latest Canary 69.0.3469.3 as per the original comment. Bisect Information: =================== Good Build: 69.0.3453.3 Bad Build : 69.0.3455.0 By running the per-revision bisect script, below is the Changelog URL. https://chromium.googlesource.com/chromium/src/+log/1eea870b8ecd2123ccf364b04f1f09b50fccddb8..172d8173353353e4966773b24944a4c02004a09d From the above Changelog, unable to find the right suspect which has caused this issue. Hence CC'ing hablich@ and requesting for help in finding the right suspect from the above changelog. Adding 'ReleaseBlock-Beta' label as this is a recent regression. Please feel free to remove if this is not applicable. Thanks
,
Jun 26 2018
Simon's CLs look suspicious, any pointers?
,
Jun 26 2018
I can repro on 69.0.3464.0, but from a first look it does not seem like Array.p.sort is called. I'll confirm tomorrow morning once back at the office.
,
Jun 27 2018
I can repro locally with latest (HEAD) of chromium and V8. After looking into it, we found an inconsistent comparison function (https://tc39.github.io/ecma262/#sec-array.prototype.sort): fsd_Mra = function(a, b) { a = fsd_Hra(a.getType()); b = fsd_Hra(b.getType()); return 0 > a ? 1 : 0 > b ? -1 : a - b }; Given two objects a and b that are both 1 (before the return), then the result of the comparison depends on the order in which they are passed in. Do we know a contact on the flights team we could get in touch with?
,
Jun 27 2018
Filed a bug: https://b.corp.google.com/issues/110866732
,
Jun 27 2018
Just to elaborate: 'fsd_Mra' is not a consistent comparison function because it is not symmetric. fsd_Mra(a, b) could return a different result than fsd_Mra(b, a). The spec requires symmetry for consistent behavior: 'If a =CF b, then b =CF a (symmetry)'
,
Jun 27 2018
The NextAction date has arrived: 2018-06-27
,
Jul 3
Friendly ping to get an update as it is marked as RBB. Thanks..!
,
Jul 3
Fixed upstream in Flights Standalone, Flights in Search, and Destination Explore, see http://b/110866732. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by craigtumblison@chromium.org
, Jun 25 2018