New issue
Advanced search Search tips

Issue 856341 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 841020



Sign in to add a comment

Keyboard Shortcut Viewer app content does not respect RTL

Project Member Reported by msw@chromium.org, Jun 25 2018

Issue description

Keyboard Shortcut Viewer app content does not respect RTL
(1) Run Chrome OS (on linux desktop) on ToT / 69.0.3469.0 with --force-ui-direction=rtl
(2) Launch the keyboard shortcut viewer (Ctrl-Alt-/)
Expected: The KSV app content respects the RTL UI, (tabs on the right).
Actual: The KSV titlebar is RTL, but app content is not (tabs on the left).

This only repros when running KSV as an app, not with --disable-features=KeyboardShortcutViewerApp
 

Comment 1 by msw@chromium.org, Jun 25 2018

ksv_rtl_expected.png
92.7 KB View Download
ksv_rtl_actual.png
81.4 KB View Download

Comment 2 by wutao@chromium.org, Jun 25 2018

Hi msw@, there is a related, possible bug in RTL: the text direction. 

Because there could be many child-labels in one line of StyledLabel, it is challenge to read the whole text after dividing the text into multiple labels in RTL but the text direction is not RTL. Is this possible? 

Please see the attached image. Should I file a new bug or there is one already?

Comment 3 by wutao@chromium.org, Jun 25 2018

KSV_RTL_text_no_flag_force-text-direction.png
8.3 KB View Download
KSV_RTL_text_with_flag_force-text-direction.png
8.3 KB View Download

Comment 4 by msw@chromium.org, Jun 25 2018

I don't think this is a really bad problem; it's the nature of doing RTL layout with LTR text.
It's definitely unrelated to this bug about mojo app content not respecting the UI direction.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d02badfaa943d7f65d5f58998392045f697df36

commit 1d02badfaa943d7f65d5f58998392045f697df36
Author: Mike Wasserman <msw@chromium.org>
Date: Wed Jun 27 19:52:24 2018

Propagate forced direction switches to the utility process

Views mojo apps (eg. Keyboard Shortcut Viewer) will use these switches.

Bug:  856341 
Test: cros KSV (Ctrl-Alt-/) respects --force-[ui|text]-direction=rtl
Change-Id: I7f0a2577c6c8dab362125f385305521cd624705f
Reviewed-on: https://chromium-review.googlesource.com/1116003
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570871}
[modify] https://crrev.com/1d02badfaa943d7f65d5f58998392045f697df36/content/browser/utility_process_host.cc

Comment 6 by msw@chromium.org, Jun 27 2018

Status: Fixed (was: Assigned)

Sign in to add a comment