New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 843350



Sign in to add a comment
link

Issue 856337: Remove Controller/Host pairing code.

Reported by alemate@chromium.org, Jun 25 2018 Project Member

Issue description

We need to remove that dead code.
 

Comment 1 by zork@chromium.org, Sep 7

Components: UI>Shell>OOBE
Labels: -Pri-1 Pri-2

Comment 2 by zalcorn@chromium.org, Nov 13

Labels: -Pri-2 Pri-3
<triage> Moving to P3 and marking available due to lack of target milestone and activity, please update if this is a priority. </triage>

Comment 3 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87cce52e1898d568f6aa5439e6183d96e7bbb914

commit 87cce52e1898d568f6aa5439e6183d96e7bbb914
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sat Dec 15 04:14:35 2018

Chrome OS: Remove dead code of Host/Controller pairing screens.

Bug:  856337 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I1fc6d0eff37bdb3f7c2175861782652ee028c4b2
Reviewed-on: https://chromium-review.googlesource.com/c/1114240
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616947}
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/BUILD.gn
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/demo_mode/demo_setup_test_utils.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/enrollment/enrollment_screen.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/enrollment/enrollment_screen_view.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/enrollment/hands_off_enrollment_browsertest.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/helper.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/oobe_screen.h
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/chromeos/login/screens/controller_pairing_screen.cc
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/chromeos/login/screens/controller_pairing_screen.h
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/chromeos/login/screens/controller_pairing_screen_view.cc
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/chromeos/login/screens/controller_pairing_screen_view.h
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/chromeos/login/screens/host_pairing_screen.cc
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/chromeos/login/screens/host_pairing_screen.h
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/chromeos/login/screens/host_pairing_screen_view.cc
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/chromeos/login/screens/host_pairing_screen_view.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/screens/mock_update_screen.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/screens/screen_exit_code.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/screens/screen_exit_code.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/screens/update_screen.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/screens/update_screen.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/screens/update_screen_unittest.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/startup_utils.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/controller-pairing-screen.html
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/controller-pairing-screen.js
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/controller_pairing_page.css
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/host-pairing-screen.html
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/host-pairing-screen.js
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/resources/chromeos/login/oobe.js
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/oobe_screen_controller_pairing.css
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/oobe_screen_controller_pairing.html
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/oobe_screen_controller_pairing.js
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.css
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.html
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.js
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/oobe_screen_host_pairing_page.css
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/resources/chromeos/login/oobe_screens.html
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/resources/chromeos/login/oobe_welcome.js
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/resources/chromeos/login/pairing_device_list.css
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc
[delete] https://crrev.com/5f3b914e3356aed49fecce8829beebd9cb754f31/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/browser/ui/webui/chromeos/login/welcome_screen_handler.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/common/pref_names.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/common/pref_names.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chrome/test/BUILD.gn
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chromeos/chromeos_switches.cc
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/chromeos/chromeos_switches.h
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/ui/login/display_manager.js
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/ui/login/md_screen_container.css
[modify] https://crrev.com/87cce52e1898d568f6aa5439e6183d96e7bbb914/ui/login/screen_container.css

Comment 4 by alemate@chromium.org, Dec 15

Status: Fixed (was: Started)

Sign in to add a comment