New issue
Advanced search Search tips

Issue 856333 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Implement FaviconLoader for Bijou Bookmarks

Project Member Reported by thegreenfrog@chromium.org, Jun 25 2018

Issue description

Use FaviconLoader to fetch favicons for Bookmarks.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 10

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Started (was: Assigned)
Labels: -Pri-0 Pri-1
Practically and realistically, this is not a P0.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef98af0fe4148c40bacccad509673b0a084464e2

commit ef98af0fe4148c40bacccad509673b0a084464e2
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Tue Sep 18 07:54:23 2018

[ios] Implement toggleable google server favicon request for FaviconLoader

This is in preparation of moving favicon logic in Bookmarks to FaviconLoader

Bug:  856333 
Change-Id: Idca0c1cf0537fd6012d6bdcd8cf6c44a7327ba2b
Reviewed-on: https://chromium-review.googlesource.com/1194568
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591965}
[modify] https://crrev.com/ef98af0fe4148c40bacccad509673b0a084464e2/ios/chrome/browser/favicon/favicon_loader.h
[modify] https://crrev.com/ef98af0fe4148c40bacccad509673b0a084464e2/ios/chrome/browser/favicon/favicon_loader.mm
[modify] https://crrev.com/ef98af0fe4148c40bacccad509673b0a084464e2/ios/chrome/browser/ui/history/history_mediator.mm
[modify] https://crrev.com/ef98af0fe4148c40bacccad509673b0a084464e2/ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
[modify] https://crrev.com/ef98af0fe4148c40bacccad509673b0a084464e2/ios/chrome/browser/ui/recent_tabs/recent_tabs_mediator.mm
[modify] https://crrev.com/ef98af0fe4148c40bacccad509673b0a084464e2/ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.mm

Status: Fixed (was: Started)

Sign in to add a comment