New issue
Advanced search Search tips

Issue 856331 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

pdf links with /Contents() display an annotation box

Reported by angelo.c...@gmail.com, Jun 25 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

Steps to reproduce the problem:
Open sample.pdf and move the mouse over the 'link to next page link'.  This will render an annotation content box.  See screen.png.  If the /Content() entry is removed the mouse over will not produce the display box.

diff -Naurb sample.pdf sample-edit.pdf
--- sample.pdf	2018-06-25 16:43:03.948296600 -0400
+++ sample-edit.pdf	2018-06-25 16:43:09.544507200 -0400
@@ -80,7 +80,7 @@
 /Type/Annot
 /Subtype/Link
 /Rect [ 70.86614 700.02362 137.65613 710.02362 ]
-/Contents (link to next page)
+                            
 /M (D:20180621095157-05'00')
 /Border[0 0  0]
 /A << /S /GoTo /D (dest1) >> >>

What is the expected behavior?
According to the PDF reference documentation, '/Content(...)' shouldn't be shown for annotations (like links) that do not display text.

    http://wwwimages.adobe.com/content/dam/Adobe/en/devnet/pdf/pdfs/pdf_reference_1-7.pdf

---- page 606 ----

Contents  text string

(Optional) Text to be displayed for the annotation or, if this type of annotation does not display text, an alternate description of the annotation’s contents in human-readable form. In either case, this text is useful when extracting the document’s contents in support of accessibility to users with disabilities or for other purposes (see Section 10.8.2, "Alternate Descriptions"). See Section 8.4.5, "Annotation Types" for more details on the meaning of this entry for each annotation type
----

What went wrong?
annotation box being displayed

Did this work before? N/A 

Chrome version: 67.0.3396.99 (Official Build) (64-bit) (cohort: 67_win_99)  Channel: n/a
OS Version: 7
Flash Version:
 
sample.pdf
3.9 KB Download
sample-edit.pdf
3.9 KB Download
screen.png
32.7 KB View Download
Components: Internals>Plugins>PDF
Labels: Needs-Triage-M67

Comment 2 by msuly...@gmail.com, Jun 26 2018

The same issue in Chrome Version 66.0.3359.181 (Official Build) (64-bit), on OS X 10.10.5.
Labels: Triaged-ET M-69 Target-69 FoundIn-69 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.13.3, Win-10 and Ubuntu 17.10 using chrome reported version #67.0.3396.99 and latest canary #69.0.3472.3.
This is a non-regression issue as it is observed from M60 old builds. 

Hence, marking it as untriaged to get more inputs from dev team.

Thanks...!!

Sending over to hnakashima@, since I think they are the correct person to look at annotation issues.
Owner: hnakashima@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/35b51e95b9a4d0c064efd905e946a554d6f47890

commit 35b51e95b9a4d0c064efd905e946a554d6f47890
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Wed Jul 25 20:25:49 2018

Create popup with Contents only for same annotations subtypes.

The subtypes are listed in "PDF Reference 1.7", page 617.

Bug:  chromium:856331 
Change-Id: I41d6094949ff22007a72ef7c1493c413c5af5f7b
Reviewed-on: https://pdfium-review.googlesource.com/38790
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/35b51e95b9a4d0c064efd905e946a554d6f47890/core/fpdfdoc/cpdf_annotlist.cpp

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2558336f62d2b75cb3b38025660c365631634892

commit 2558336f62d2b75cb3b38025660c365631634892
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jul 26 01:18:45 2018

Roll src/third_party/pdfium a5d2bf1131fe..91b8302dec04 (3 commits)

https://pdfium.googlesource.com/pdfium.git/+log/a5d2bf1131fe..91b8302dec04


git log a5d2bf1131fe..91b8302dec04 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 tsepez@chromium.org Use incomplete type CFX_BmpContext in place of void*
2018-07-25 thestig@chromium.org Change GetHeaderOffset() to return Optional<FX_FILESIZE>.
2018-07-25 hnakashima@chromium.org Create popup with Contents only for same annotations subtypes.


Created with:
  gclient setdep -r src/third_party/pdfium@91b8302dec04

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:856331 
TBR=dsinclair@chromium.org

Change-Id: I057ec93d3344dec364419351204f575254990b25
Reviewed-on: https://chromium-review.googlesource.com/1150368
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578158}
[modify] https://crrev.com/2558336f62d2b75cb3b38025660c365631634892/DEPS

Comment 10 Deleted

problem still occurs with 69.0.3497.81 (Official Build) (64-bit)

Sign in to add a comment