New issue
Advanced search Search tips

Issue 856314 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Deprecate Python trace model

Project Member Reported by nednguyen@chromium.org, Jun 25 2018

Issue description

This is the cover bug for deprecating Telemetry's python trace parsing code (https://github.com/catapult-project/catapult/tree/master/telemetry/telemetry/timeline). We already have a trace parser written in Javascript (https://github.com/catapult-project/catapult/tree/master/tracing), and trace parsing is pretty complex, hence remove the python version.


 
Cc: perezju@chromium.org benjhayden@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/11513e359cd60e369bbbd1f4f2ef648c1bccabd0

commit 11513e359cd60e369bbbd1f4f2ef648c1bccabd0
Author: Nghia Nguyen <nednguyen@google.com>
Date: Tue Jun 26 10:50:50 2018

Add convenient method for running trace processing code in python

This allows us to gradually remove usage of python trace model in Telemetry unittest (see changes to telemetry/telemetry/core/tracing_controller_unittest.py)

Change-Id: Ifce2a6c715ab6b33214f51ffcc4b214573fb8734

BUG=chromium:856314

Change-Id: Ifce2a6c715ab6b33214f51ffcc4b214573fb8734
Reviewed-on: https://chromium-review.googlesource.com/1111598
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/11513e359cd60e369bbbd1f4f2ef648c1bccabd0/telemetry/telemetry/core/tracing_controller_unittest.py
[modify] https://crrev.com/11513e359cd60e369bbbd1f4f2ef648c1bccabd0/tracing/tracing/mre/map_single_trace_unittest.py
[add] https://crrev.com/11513e359cd60e369bbbd1f4f2ef648c1bccabd0/tracing/tracing/mre/test_trace.json
[add] https://crrev.com/11513e359cd60e369bbbd1f4f2ef648c1bccabd0/telemetry/telemetry/util/trace_runner.py
[modify] https://crrev.com/11513e359cd60e369bbbd1f4f2ef648c1bccabd0/tracing/tracing/mre/map_single_trace.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55745aeb47e78ab411e8fdccb3bcb0ce40c8f160

commit 55745aeb47e78ab411e8fdccb3bcb0ce40c8f160
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 26 12:12:54 2018

Roll src/third_party/catapult 8d2c28ec7666..11513e359cd6 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/8d2c28ec7666..11513e359cd6


git log 8d2c28ec7666..11513e359cd6 --date=short --no-merges --format='%ad %ae %s'
2018-06-26 nednguyen@google.com Add convenient method for running trace processing code in python


Created with:
  gclient setdep -r src/third_party/catapult@11513e359cd6

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:856314
TBR=sullivan@chromium.org

Change-Id: I6b84e01aeb8be822b7b117efbeb7ca0d20e6e7cb
Reviewed-on: https://chromium-review.googlesource.com/1113791
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570379}
[modify] https://crrev.com/55745aeb47e78ab411e8fdccb3bcb0ce40c8f160/DEPS

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 5 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment