Chrome OS keyboard shortcut viewer tabbed pane focused tab appearance |
|||
Issue descriptionChrome OS keyboard shortcut viewer tabbed pane focused tab appearance (1) Run Chrome OS (on linux desktop) on ToT / 69.0.3469.0 (2) Launch the keyboard shortcut viewer (Ctrl-Alt-/) (3) Observe the selected tab appearance and hit the Tab key. Expected: The selected tab should show focus in a nice way. Actual: The selected tab show focus with an ugly filled rect. It might be nice to outline the shape of the selected tab itself? I imagine PM/UX might have some input for the desired appearance. See the attached screenshots. Tao, can you take a look? Thanks.
,
Jun 25 2018
+sgabriel@ Or make the ring a little larger than the highlighted background?
,
Jun 25 2018
FWIW, I think it'd be nice to show a focus ring that follows the contours of the tab highlight round rect.
,
Jun 25 2018
Focus for this is defined as a darker shade of blue, following the spec here. https://drive.google.com/open?id=16UgdCDlKqKksvzFnL2NvIkaw9AKyXAVi&authuser=sgabriel@google.com I think we should do that. I believe this issue is happening when switching the harmony flag on.
,
Jun 25 2018
Thanks sgabriel@, we can change the color of highlighted rect. But I do not see "focus ring" in the spec when the tab is focused. Do we show that "focus ring" at all?
,
Jun 25 2018
It replaces the focus ring.
,
Jun 25 2018
Thank you sgabriel@.
,
Jun 25 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wutao@chromium.org
, Jun 25 2018