New issue
Advanced search Search tips

Issue 856292 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Delayed Chromium OS boot with upstream kernel

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36

Steps to reproduce the problem:
1. Checkout out upstream kernel
2. Build and flash kernel
3. Boot takes approx 3 mins 

What is the expected behavior?
Chromium OS boots within 8 sec.

What went wrong?
Recently I have noticed that booting with upstream kernel(v4.18) on Chromebook takes longer(~2 mins) than usual. Basically, boot sequence spent more time at Chromium OS logo.

I have identified the patch which is related to security:

commit 43838a23a05fbd13e47d750d3dfd77001536dd33
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Wed Apr 11 13:27:52 2018 -0400

    random: fix crng_ready() test

Patch is addresses: https://bugs.chromium.org/p/project-zero/issues/detail?id=1559 ; refer https://security-tracker.debian.org/tracker/CVE-2018-1108 for more details. 

Reverting this patch fixes the issue. However, as this is security related patch reverting is not long term solution.

*Note: Debian (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897958) found similar issue  and was fixed in userspace (plymouth/0.9.3-3 package).

Did this work before? Yes 

Chrome version: 67.0.3396.87  Channel: dev
OS Version: 10.0
Flash Version:
 

Comment 1 by groeck@chromium.org, Jun 25 2018

Cc: apronin@chromium.org
Components: OS>Kernel
Labels: Kernel-upstream
Owner: groeck@chromium.org
Status: Assigned (was: Unconfirmed)
Known problem, inherited into Chrome OS 4.4/4.14 with stable release merges. Addressed in chromeos-4.14 with commits 6ea9c796a353 ("CHROMIUM: tpm: cr50_i2c: Set hwrng quality") and 845bb32b39aa ("CHROMIUM: tpm: Restore quality of tpm-rng to 1000"). Addressed in chromeos-4.4 with commit d8669c9a35e6 ("CHROMIUM: tpm-rng: Make hwrng working").
I don't know if there is a feasible upstream solution. Will leave bug open for tracking.

Cc: louiscollard@chromium.org
There is no upstream solution yet, there is this proposed patch that will allow setting hwrng quality: https://patchwork.kernel.org/patch/10453911/. 

Once it is accepted, CLs like this will be able to set quality on a per-tpm model level: https://crrev.com/c/1090595.

Also tracked in  issue 827682 .

Comment 3 by groeck@chromium.org, Jun 25 2018

Looks like https://patchwork.kernel.org/patch/10453911/ was rejected due to a formality (which doesn't make sense to me since it applies cleanly to the upstream kernel and to -next). Any idea what "not connected to the current GIT tree" is supposed to mean ?

I'm not sure what it meant but have just replied (sorry for the delay in doing so) - will keep on top of it until we reach some conclusion..
Status: Fixed (was: Assigned)
Fix is upstream with commit 7a64c5597aa4 ("tpm: Allow tpm_tis drivers to set hwrng quality."). Marking Fixed.


Sign in to add a comment