Chrome OS keyboard shortcut viewer tabbed pane text inset bug |
||
Issue descriptionChrome OS keyboard shortcut viewer tabbed pane text inset bug (1) Run Chrome OS (on linux desktop) on ToT / 69.0.3469.0 (2) Launch the keyboard shortcut viewer (Ctrl-Alt-/) (3) Press the Tab key to focus the first tabbed pane tab (4) Press the Down arrow key once or twice (or Up arrow key...) (5) Click the "Search for keyboard shortcuts" textfield. Expected: The tabbed pane tab text doesn't change position Actual: The tabbed pane tab text moves over to the left See the attached screenshot
,
Jun 25 2018
Looks like only the tabs have been "activated" has this problem. Maybe some logic is wrong in the TabbedPane how to set the insets in different modes. Will look into this.
,
Jun 25 2018
I think I found the issue, it is related to bug 856297 . Because MdTab reset its border but did not restore it, so we lost the horizontal padding (32px). How about I proposed in bug 856297 : If it is MdTab in vertical and highlighted mode, we do not set the border of MdTab?
,
Jun 25 2018
The link [1] for #3. we also can fix this bug along to introduce a variable old_border and restore to that border OnBlur. https://cs.chromium.org/chromium/src/ui/views/controls/tabbed_pane/tabbed_pane.cc?l=386&rcl=98cf9db6f3c35b814e26ae9eb34564209397d86d
,
Jun 25 2018
I'd try replacing the call to CreateSolidBorder at line 377 with CreateSolidSidedBorder (that should persist the per-side insets, not just the top inset). Hopefully that wouldn't break the other tabbed pane user, the collected cookies view, accessible via the page info bubble. Otherwise MdTab could cache its unfocused insets to restore those on Blur. I guess we could also avoid changing the border altogether for vertical mode...
,
Jun 26 2018
Will use the third option because it also fixes another bug 856297 .
,
Jun 26 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by msw@chromium.org
, Jun 25 2018