Issue metadata
Sign in to add a comment
|
A11y regression: Conversation list in hangouts no longer accessible |
||||||||||||||||||||||
Issue descriptionBad chrome: 69.0.3472.0 (Official Build) canary (64-bit) (cohort: Clang-64) Good Chrome: 68.0.3440.33 (Official Build) beta (64-bit) (cohort: Beta) NVDA: 2018.2.1 JAWS: 2018 Steps to repro: # With NVDA running, visit hangouts.google.com # Sign in and start 2 conversations # focus the conversation select box and press enter to enter focus mode # Use up and down arrow to navigate # Notice that NVDA says 'button' # Try the same in Chrome beta and notice that names of conversations are read Expected: NVDA should read conversation names Actual: It reads buttons. You are probably looking for a change made after 566621 (known good), but no later than 566622 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7a8e4dfa00eaeb6a7e41381f29060c6c1f38ac19..6589a857b53023b5c12f85194583f13da2466264
,
Jun 26 2018
,
Jun 27 2018
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ffc8d34a79469cba7e63d7cf176ec6a9caf136b commit 4ffc8d34a79469cba7e63d7cf176ec6a9caf136b Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu Jun 28 15:43:08 2018 Layout table roles should provide name from contents when used recursively. Recent table refactoring means we expose more layout tables. This is generally a good thing. It broke some accessibility in Hangouts, where there was a layout table inside of an ARIA button and the accessible text of the button came from inside the layout table. Previously the layout table was just exposed as generic elements, and layout table roles should behave the same way with regards to how text is exposed to ancestors. Bug: 856277 Change-Id: I9b30931b306fda09a5408df4dc3b3dd1c54e619e Reviewed-on: https://chromium-review.googlesource.com/1117628 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#571139} [modify] https://crrev.com/4ffc8d34a79469cba7e63d7cf176ec6a9caf136b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc [add] https://crrev.com/4ffc8d34a79469cba7e63d7cf176ec6a9caf136b/content/test/data/accessibility/html/layout-table-in-button-expected-blink.txt [add] https://crrev.com/4ffc8d34a79469cba7e63d7cf176ec6a9caf136b/content/test/data/accessibility/html/layout-table-in-button.html [modify] https://crrev.com/4ffc8d34a79469cba7e63d7cf176ec6a9caf136b/third_party/blink/renderer/modules/accessibility/ax_object.cc
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12ddfc928fd5f15319daf84b3c529f0ca5ad8546 commit 12ddfc928fd5f15319daf84b3c529f0ca5ad8546 Author: Yi Gu <yigu@chromium.org> Date: Thu Jun 28 17:49:53 2018 Revert "Layout table roles should provide name from contents when used recursively." This reverts commit 4ffc8d34a79469cba7e63d7cf176ec6a9caf136b. Reason for revert: Consistently failed the bot https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Audio%20Linux Original change's description: > Layout table roles should provide name from contents when used recursively. > > Recent table refactoring means we expose more layout tables. This is > generally a good thing. > > It broke some accessibility in Hangouts, where there was a layout table > inside of an ARIA button and the accessible text of the button came from > inside the layout table. Previously the layout table was just exposed as > generic elements, and layout table roles should behave the same way with > regards to how text is exposed to ancestors. > > Bug: 856277 > Change-Id: I9b30931b306fda09a5408df4dc3b3dd1c54e619e > Reviewed-on: https://chromium-review.googlesource.com/1117628 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571139} TBR=dmazzoni@chromium.org,aleventhal@chromium.org Change-Id: I496fb5987f7155064193ae475d45a00c7dbbb3b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856277 Reviewed-on: https://chromium-review.googlesource.com/1118945 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571193} [modify] https://crrev.com/12ddfc928fd5f15319daf84b3c529f0ca5ad8546/content/browser/accessibility/dump_accessibility_tree_browsertest.cc [delete] https://crrev.com/cf1dbf5364129a43a82f8430c53602dd74ffe646/content/test/data/accessibility/html/layout-table-in-button-expected-blink.txt [delete] https://crrev.com/cf1dbf5364129a43a82f8430c53602dd74ffe646/content/test/data/accessibility/html/layout-table-in-button.html [modify] https://crrev.com/12ddfc928fd5f15319daf84b3c529f0ca5ad8546/third_party/blink/renderer/modules/accessibility/ax_object.cc
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bc006793c618e8e049c5790f67f1cc5cb994da3 commit 6bc006793c618e8e049c5790f67f1cc5cb994da3 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Fri Jun 29 18:47:27 2018 Re-land: Layout table roles should provide name from contents when used recursively. Originally landed: crrev.com/c/1117628 Reverted: crrev.com/c/1118945 The test output just needed to be rebaselined because another change that landed at around the same time eliminated some of the extra table nodes from the AX tree. TBR=aleventhal@chromium.org Bug: 856277 Change-Id: I6c22a0ff4af5322378207253fc260365f0efcbe4 Reviewed-on: https://chromium-review.googlesource.com/1120636 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#571568} [modify] https://crrev.com/6bc006793c618e8e049c5790f67f1cc5cb994da3/content/browser/accessibility/dump_accessibility_tree_browsertest.cc [add] https://crrev.com/6bc006793c618e8e049c5790f67f1cc5cb994da3/content/test/data/accessibility/html/layout-table-in-button-expected-blink.txt [add] https://crrev.com/6bc006793c618e8e049c5790f67f1cc5cb994da3/content/test/data/accessibility/html/layout-table-in-button.html [modify] https://crrev.com/6bc006793c618e8e049c5790f67f1cc5cb994da3/third_party/blink/renderer/modules/accessibility/ax_object.cc
,
Jul 9
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aleventhal@chromium.org
, Jun 26 2018