AdTracker should only be created if the AdTagging is enabled |
||
Issue descriptionAdTracker may have noticable impact on performance and we need to track it. So let's gate the creation of it on the AdTagging field trial.
,
Aug 8
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/438caa21caa4c4ded95c0d6ab70d58d70fbb154a commit 438caa21caa4c4ded95c0d6ab70d58d70fbb154a Author: Josh Karlin <jkarlin@chromium.org> Date: Wed Oct 17 18:06:08 2018 [AdTagging] Fix disabled test The test was supposed to verify that, when AdTagging is disabled, frames with ad urls aren't tagged as ads. This wasn't working as intended. It passed regardless of whether or not ad tagging was disabled. What the test wanted to do isn't really possible when an AdTracker isn't present, and it's not when AdTagging is disabled. Changed the test to verify that the AdTracker is not present when AdTagging is disabled. Bug: 856273 Change-Id: I6e31444774ed5c1d1a9156a2a16e92896909d8fa Reviewed-on: https://chromium-review.googlesource.com/c/1273816 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600477} [modify] https://crrev.com/438caa21caa4c4ded95c0d6ab70d58d70fbb154a/third_party/blink/renderer/core/frame/ad_tracker_test.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 19