New issue
Advanced search Search tips

Issue 856266 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Allow render-initiated freezing in resource coordinator

Project Member Reported by shaseley@google.com, Jun 25 2018

Issue description

TabLifecycleUnit currently doesn't allow active -> frozen transitions, which are possible from the renderer when enabled with the stop-in-background feature. When this flag is enabled on desktop, freezing causes a DCHECK failure. This isn't currently an issue in the field since TabManager isn't enabled on Android, but will be needed going forward.
 

Comment 1 by fmeawad@google.com, Jun 26 2018

We also want to start experimenting with renderer-initiated freezing on Desktop.

In general, I think that renderer initiated freezing should be allowed on Desktop.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a18d47428d64d9ae3b4138b2bb97d113c2c95646

commit a18d47428d64d9ae3b4138b2bb97d113c2c95646
Author: Scott Haseley <shaseley@google.com>
Date: Wed Jun 27 02:10:50 2018

RC: Fix DCHECK failure on render-initiated freezing.

Allow Active --> Frozen state transitions, but only from the renderer. This
is the expected state transition for renderer-initiated freezing.

Bug:  856266 
Change-Id: I4aae9e3cba4c60d118e026fb185cf274a5645d58
Reviewed-on: https://chromium-review.googlesource.com/1113956
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#570634}
[modify] https://crrev.com/a18d47428d64d9ae3b4138b2bb97d113c2c95646/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc

Status: Fixed (was: Started)
Effectively reverted in crrev.com/c/1182516. Render-initiated freezing is now only allowed on Android.

Sign in to add a comment