New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 856251 link

Starred by 1 user
Status: Fixed
Owner:
█ sawtelle@google.com
Last visit > 30 days ago
Closed: Jul 19
Cc:
█ apaci...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Picture-in-Picture] Id of custom control not passable when called

Project Member Reported by sawtelle@google.com, Jun 25 2018 
When a custom control is clicked, it fires a custom event that contains a string that is the id. Right now this id is hardcoded as a test value. Instead, it should determine the value for the id from the name of the custom control that was clicked and pass that through.

Comment 1 by sawtelle@google.com, Jun 25 2018

Labels: M-69

Comment 2 by mlamouri@chromium.org, Jul 5

Labels: -M-69 M-70

Comment 3 by mlamouri@chromium.org, Jul 5

Labels: -M-70 Target-70
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3

commit 82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3
Author: sawtelle <sawtelle@google.com>
Date: Thu Jul 19 04:33:12 2018

[Picture in Picture] Create plumbing to pass the id of custom controls.

This change addresses crbug 856251 and allows for strings to be passed
through the call stack when a custom control is clicked.

Currently this is not being used, but in the future this plumbing will be
connected to developer-defined custom controls that have unique ids.

Bug:  856251 
Change-Id: Ie8305104d677afcccf3223a1fabb94a9f376710e
Reviewed-on: https://chromium-review.googlesource.com/1119082
Commit-Queue: Steven Sawtelle <sawtelle@google.com>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576369}
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/chrome/browser/ui/views/overlay/overlay_window_views.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/chrome/test/data/media/picture-in-picture/window-size.html
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/content/common/media/media_player_delegate_messages.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/content/public/browser/picture_in_picture_window_controller.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/content/renderer/media/renderer_webmediaplayer_delegate.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/content/renderer/media/renderer_webmediaplayer_delegate.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/media/blink/webmediaplayer_delegate.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/third_party/blink/public/platform/web_media_player_client.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/third_party/blink/renderer/core/html/media/html_audio_element.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.idl
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/82e4b750b2dc0c2cb6828e1ae851f62bb29e51d3/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.h

Comment 5 by sawtelle@google.com, Jul 19

Status: Fixed (was: Assigned)
►

Sign in to add a comment