New issue
Advanced search Search tips

Issue 856249 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Previous locations:
gerrit:9339


Sign in to add a comment

Revert / Reland button text should clearly indicate what will happen on click.

Project Member Reported by cbruni@chromium.org, Jun 25 2018

Issue description

Quite a few people from our team (V8) are not using the revert / reland button since it gives the impression of immediately doing the action.

I think this comes from the fact that revert/reland behave slightly different. Reland creates a new CL, while revert lands the CL immediately.
(I'm probably wrong about, in which case this applies even more :P)

Would it be possible to include a verb in the button describing what it does?

"Reland" => "Create Reland"
"Revert" => "Land Revert"

In my experience we have to touch up a CL quite often, so manually clicking land on the newly created CL 
 

Comment 1 by kaspern@google.com, Jun 25 2018

Labels: -Type-Bug -Priority-3
I'm going to bounce this over to the Chrome Infra team, they provide the "Reland" behavior via a plugin.

Feel free to re-file or bounce this back over to Gerrit if there's any AIs for us.

Comment 2 by kaspern@google.com, Jun 25 2018

Project: chromium
Moved issue gerrit:9339 to now be issue chromium:856249.

Comment 3 by kaspern@google.com, Jun 25 2018

Components: Infra>Codereview>Gerrit
Labels: Pri-2 Type-Feature
Status: Available (was: New)
Summary: Revert / Reland button text should clearly indicate what will happen on click. (was: Revert / Reland button should be less scary)
This would be a change in our chromium behavior plugin

Sign in to add a comment