Link data prompt for enterprise |
||||
Issue descriptionThe link data prompt in enterprise needs to have the enterprise icon See attached image. Assigning to zmin@ for now, please assign to relevant owner
,
Jul 12
Makes sense. Will update the dialog. Also this being tracked on this bug as well https://bugs.chromium.org/p/chromium/issues/detail?id=678803
,
Jul 12
Updated with suggested content and padding. Reference: https://docs.google.com/presentation/d/1Q6Pn0YB1UgH1QKiSMQadTjStMMXKVoH60nb9QN3ee1o/edit?usp=sharing
,
Jul 13
Thanks, one question: What does the "create new profile" link point to? Is it a help center article or same behavior of "Create a New Profile" button?
,
Jul 18
+others The new dialog looks more than just adding an icon thus the work is not trivial anymore. Especially the dialog is implemented by object c on mac. Do we want to 1) Add the icon ASAP and do other changes later. OR 2) Do everything together but the task needs to be prioritized.
,
Jul 18
1. Can we add an icon ASAP 2. And follow up with remaining changes? There is an ongoing discussion around this dialog on this thread: https://bugs.chromium.org/p/chromium/issues/detail?id=678803 Once we have the final strings, we can look at making all the remaining changes together. I think is an important modal which I believe is seen by lot of enterprise users so happy to help prioritize this.
,
Jul 25
Hi Namrata, I have created a CL to add this icon on Win/Linux first and here is the screenshot. Please take a look before I send it to code review.
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5de2bdef11c5c9f20f3830bd1b4aeb74fc969a8 commit a5de2bdef11c5c9f20f3830bd1b4aeb74fc969a8 Author: Owen Min <zmin@chromium.org> Date: Mon Aug 06 15:30:52 2018 Add enterprise icon to the ProfileSigninConfirmationDialog Screenshot: https://drive.google.com/file/d/1ipME4JlplC_99fQzx6lukvmHUyA3MUfG/view?usp=sharing Bug: 856242 Change-Id: I5f70c8b697de5b310019258ad79c27f975b7ce36 Reviewed-on: https://chromium-review.googlesource.com/1162342 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580879} [modify] https://crrev.com/a5de2bdef11c5c9f20f3830bd1b4aeb74fc969a8/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
,
Aug 9
|
||||
►
Sign in to add a comment |
||||
Comment 1 by zmin@chromium.org
, Jul 4