New issue
Advanced search Search tips

Issue 856242 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Link data prompt for enterprise

Project Member Reported by namratakannan@chromium.org, Jun 25 2018

Issue description

The link data prompt in enterprise needs to have the enterprise icon
See attached image.
Assigning to zmin@ for now, please assign to relevant owner
 
Enteprise link data.png
450 KB View Download
link data_spec.png
612 KB View Download
"Link your Chrome data to this account" is the title of the dialog which is string only in the UI framework. It will be much easier if the icon is put into the body of the dialog. i.e. Before "This account is managed by ..."
Makes sense. Will update the dialog. Also this being tracked on this bug as well
https://bugs.chromium.org/p/chromium/issues/detail?id=678803
Updated with suggested content and padding.
Reference:
https://docs.google.com/presentation/d/1Q6Pn0YB1UgH1QKiSMQadTjStMMXKVoH60nb9QN3ee1o/edit?usp=sharing
Link data profile.png
555 KB View Download
Thanks, one question: What does the "create new profile" link point to? Is it a help center article or same behavior of "Create a New Profile" button?
Cc: rogerta@chromium.org privard@chromium.org georgesak@chromium.org
+others
The new dialog looks more than just adding an icon thus the work is not trivial anymore. Especially the dialog is implemented by object c on mac.

Do we want to
1) Add the icon ASAP and do other changes later.
OR
2) Do everything together but the task needs to be prioritized. 
1. Can we add an icon ASAP

2. And follow up with remaining changes? There is an ongoing discussion around this dialog on this thread:
https://bugs.chromium.org/p/chromium/issues/detail?id=678803
Once we have the final strings, we can look at making all the remaining changes together. I think is an important modal which I believe is seen by lot of enterprise users so happy to help prioritize this.


Hi Namrata,

I have created a CL to add this icon on Win/Linux first and here is the screenshot. Please take a look before I send it to code review.
profile_confirm_with_icon.png
24.0 KB View Download
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5de2bdef11c5c9f20f3830bd1b4aeb74fc969a8

commit a5de2bdef11c5c9f20f3830bd1b4aeb74fc969a8
Author: Owen Min <zmin@chromium.org>
Date: Mon Aug 06 15:30:52 2018

Add enterprise icon to the ProfileSigninConfirmationDialog

Screenshot: https://drive.google.com/file/d/1ipME4JlplC_99fQzx6lukvmHUyA3MUfG/view?usp=sharing

Bug:  856242 
Change-Id: I5f70c8b697de5b310019258ad79c27f975b7ce36
Reviewed-on: https://chromium-review.googlesource.com/1162342
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580879}
[modify] https://crrev.com/a5de2bdef11c5c9f20f3830bd1b4aeb74fc969a8/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc

Status: Fixed (was: Assigned)

Sign in to add a comment