New issue
Advanced search Search tips

Issue 856235 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 840391



Sign in to add a comment

oopash: Startup crash in KeyboardController::EnableKeyboard in ash

Project Member Reported by jamescook@chromium.org, Jun 25 2018

Issue description

CHROMEOS_RELEASE_DESCRIPTION=10816.0.0 (Official Build) dev-channel eve test
chrome ToT c76adeae3e450120bf2f7a47e5a26121087e14e7

Run with --enable-features=OopAsh in /etc/chrome_dev.conf

[20856:20856:0625/091325.817666:ERROR:shell_delegate_mash.cc(64)] Not implemented reached in virtual std::unique_ptr<keyboard::KeyboardUI> ash::ShellDelegateMash::CreateKeyboardUI()
Received signal 11 SEGV_MAPERR 000000000000
#0 0x58fb2bb2747c base::debug::StackTrace::StackTrace()
#1 0x58fb2bb26fe1 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f5ad274c2e0 <unknown>
#3 0x58fb2d265cea keyboard::KeyboardController::EnableKeyboard()
#4 0x58fb2da8494f ash::Shell::EnableKeyboard()
#5 0x58fb2db5cdeb ash::VirtualKeyboardController::UpdateKeyboardEnabled()
#6 0x58fb2ab3cd6e chromeos::input_method::InputMethodManagerImpl::NotifyImeMenuListChanged()
#7 0x58fb2c5e3a2f ui::EventFactoryEvdev::DispatchTouchscreenDevicesUpdated()
#8 0x58fb2baa440c base::debug::TaskAnnotator::RunTask()
#9 0x58fb2babba77 base::MessageLoop::RunTask()
#10 0x58fb2babbf67 base::MessageLoop::DoWork()
#11 0x58fb2bb38069 base::MessagePumpLibevent::Run()
#12 0x58fb2badc225 base::RunLoop::Run()
#13 0x58fb2b779feb content::UtilityMain()
#14 0x58fb2b796a80 content::ContentMainRunnerImpl::Run()
#15 0x58fb2b79f897 service_manager::Main()
#16 0x58fb2b794ba1 content::ContentMain()
#17 0x58fb295d5a7f ChromeMain
#18 0x7f5ad1b20736 __libc_start_main
#19 0x58fb295d58b9 _start
  r8: 0000000000000000  r9: 00007f5ad15fa740 r10: 73614d6574616765 r11: 0000000000000000
 r12: 0000000085f82500 r13: 00007ffd34ec6080 r14: 000032aa862dff40 r15: 00007ffd34ec5d40
  di: 0000000000000000  si: 00007ffd34ec5d40  bp: 00007ffd34ec5cf0  bx: 000032aa86084780
  dx: 000032aa862dff40  ax: 0000000000000000  cx: 000058fb2bb34480  sp: 00007ffd34ec5cd0
  ip: 000058fb2d265cea efl: 0000000000010246 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

The weird thing is that chromeos::input_method::InputMethodManagerImpl is code in //chrome/browser/chromeos, but this is a utility process (probably the ash process). How is it running browser code? A factory method deep in //ui/keyboard?

 
Blocking: 840391
Owner: msw@chromium.org
Status: Assigned (was: Untriaged)
One other theory is this might be a ui service process trying to start up. See  issue 856232 

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cebe6768afd5d73e9d1bea19a450a134ecf14e31

commit cebe6768afd5d73e9d1bea19a450a134ecf14e31
Author: Mike Wasserman <msw@chromium.org>
Date: Thu Jun 28 23:01:35 2018

OopAsh: Bail on Shell::EnableKeyboard in Mash and OopAsh.

ShellDelegateMash does not create a valid keyboard ui instance.

TBR=blakeo@chromium.org

Bug:  856235 ,  646565 
Test: No keyboard crash on --enable-features=OopAsh device startup.
Change-Id: I26ac1c13f46b839a4b77c6aaf478abec745126f1
Reviewed-on: https://chromium-review.googlesource.com/1119088
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571313}
[modify] https://crrev.com/cebe6768afd5d73e9d1bea19a450a134ecf14e31/ash/shell.cc
[modify] https://crrev.com/cebe6768afd5d73e9d1bea19a450a134ecf14e31/ui/keyboard/keyboard_controller.cc

Comment 4 by msw@chromium.org, Jun 28 2018

Status: Fixed (was: Assigned)

Sign in to add a comment